Defect #26310

"attachment:filename" should generate a link to preview instead of download

Added by Go MAEDA 12 months ago. Updated 12 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Text formatting
Target version:-
Resolution:Fixed Affected version:

Description

The default behavior of links to an attachment has been switched from downloading to previewing by #25988 for 3.4.0.
But I noticed that "attachment:filename" in wiki formatting still generates a download link. This should be changed to preview link for consistency.

defect-attachment-link@2x.png (31.5 KB) Go MAEDA, 2017-07-02 07:56

fix-attachment-link-destination.diff Magnifier - patch (1.91 KB) Go MAEDA, 2017-07-02 08:01


Related issues

Related to Redmine - Feature #25988: Preview files by default instead of downloading them Closed

Associated revisions

Revision 16738
Added by Jean-Philippe Lang 12 months ago

"attachment:filename" should generate a link to preview instead of download (#26310, #25988).

History

#1 Updated by Go MAEDA 12 months ago

  • Related to Feature #25988: Preview files by default instead of downloading them added

#2 Updated by Go MAEDA 12 months ago

  • Target version set to 3.4.0

I understand it is a bit late, but please include this small fix in 3.4.0 if possible.

#3 Updated by Mischa The Evil 12 months ago

LGTM. It would indeed be nice if this could still be delivered along with #25988.

#4 Updated by Jean-Philippe Lang 12 months ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang
  • Target version deleted (3.4.0)
  • Resolution set to Fixed

Committed, thanks.

Also available in: Atom PDF