Defect #26620

Wrong text of submit button on search page

Added by Dmitry Lisichkin 4 months ago. Updated 16 days ago.

Status:Needs feedbackStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Translations
Target version:4.1.0
Resolution: Affected version:

Description

:button_search is more intuitive then :button_submit

fix_button_text.patch Magnifier (542 Bytes) Dmitry Lisichkin, 2017-08-03 17:33

History

#1 Updated by Toshi MARUYAMA 4 months ago

  • Status changed from New to Needs feedback

Where is "button_search" defined?
"button_submit" is defined at source:trunk/config/locales/en.yml@16905#L1030 .

#2 Updated by Dmitry Lisichkin 4 months ago

Sorry, I didn't notice that button_search is not defined in core.
I just try to remove maximum of patches from our plugins=).
Problem that button_submit have translations that not always appropriate in some contexts.
In russian it translated as "Принять" and it looks very strange on search page but looks normal on most of other forms.
So I think was good if button_search would be in core too.

#3 Updated by Toshi MARUYAMA 3 months ago

Dmitry Lisichkin wrote:

So I think was good if button_search would be in core too.

Do you think :button_search should be used in only app/views/search/index.html.erb?
In other word, other :button_submit should be kept?

#4 Updated by Toshi MARUYAMA 3 months ago

  • Category changed from UI to Translations

#5 Updated by Toshi MARUYAMA 3 months ago

What do you think :button_search should be in English en.yml?

#6 Updated by Dmitry Lisichkin about 1 month ago

Sorry for long response.
Yes I think button_search should be in en.yaml even with only one usage in view.
IMHO "search"-button on search form is much better then "submit"-button.

#7 Updated by Toshi MARUYAMA 16 days ago

  • Target version set to 4.1.0

Also available in: Atom PDF