Project

General

Profile

Actions

Defect #26836

closed

Filtering issues via context menu should not reset selected columns

Added by Vincent Robert over 6 years ago. Updated about 5 years ago.

Status:
Closed
Priority:
Normal
Category:
Issues list
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

If we use the context menu to filter issues, selected columns are reset to default.

Steps to reproduce this bug:

  1. On /issues, change selected column and apply
  2. Check several issues
  3. Apply "filter" in context menu
  4. The query is applied: issues are well selected, but we lose our selected columns


Files

02.png (161 KB) 02.png Vincent Robert, 2017-09-04 10:43
03.png (206 KB) 03.png Vincent Robert, 2017-09-04 10:43
01.png (244 KB) 01.png Vincent Robert, 2017-09-04 10:43
Actions #1

Updated by Marius BÄ‚LTEANU almost 6 years ago

  • Status changed from New to Confirmed
Actions #2

Updated by Vincent Robert about 5 years ago

  • Target version set to 4.0.3
  • Affected version changed from 3.4.2 to 4.0.2
Actions #3

Updated by Vincent Robert about 5 years ago

Here is a basic implementation to fix this bug:

diff --git a/app/controllers/context_menus_controller.rb b/app/controllers/context_menus_controller.rb
index bd6977503..bef2826a4 100644
--- a/app/controllers/context_menus_controller.rb
+++ b/app/controllers/context_menus_controller.rb
@@ -43,6 +43,9 @@ class ContextMenusController < ApplicationController
     @priorities = IssuePriority.active.reverse
     @back = back_url

+    params = CGI.parse(@back)
+    @columns = params["c[]"]
+
     @options_by_custom_field = {}
     if @can[:edit]
       custom_fields = @issues.map(&:editable_custom_fields).reduce(:&).reject(&:multiple?).select {|field| field.format.bulk_edit_supported}
diff --git a/app/views/context_menus/issues.html.erb b/app/views/context_menus/issues.html.erb
index 7919472af..f979cd0e2 100644
--- a/app/views/context_menus/issues.html.erb
+++ b/app/views/context_menus/issues.html.erb
@@ -134,7 +134,7 @@
 <% end %>

 <% unless @issue %>
-  <li><%= context_menu_link l(:button_filter), _project_issues_path(@project, :set_filter => 1, :status_id => "*", :issue_id => @issue_ids.join(",")),
+  <li><%= context_menu_link l(:button_filter), _project_issues_path(@project, :set_filter => 1, :status_id => "*", :issue_id => @issue_ids.join(","), :c => @columns),
           :class => 'icon icon-list' %></li>
 <% end %>
Actions #4

Updated by Jean-Philippe Lang about 5 years ago

  • Status changed from Confirmed to Closed
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed, thanks. I made a slight change after that in order not to manually parse the back_url.

Actions

Also available in: Atom PDF