Patch #27807

Use a unique way to check/uncheck a group/fieldset with checkboxes

Added by Marius BALTEANU about 1 month ago. Updated 12 days ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

Currently, there are 2 ways to check/uncheck a group/fieldset with checkboxes:

1. Using the green tick icon in screens like:
- New member modal
- Workflow, tab Status transitions

2. Using the explicit links "Check All/Uncheck All" in screens like
- New tracker form
- New custom field form

This series of patches propose the following changes:
3. add the the toggle feature (from point 1) to several screens:
- Active activities from Time tracking tab (Project settings)
- Trackers and custom fields settings from Issues tracking tab (Project settings)
- Project modules settings (Project settings)
- Roles permissions for each module (Administration)

4. Replace the explicit links from the above mentioned screens (point 2) with the toggle feature.
5. Some CSS cleanup
6. Fix a current issue in new member modal where the icon is rendered after the fieldset name and not before it.

In this way, will have a unique and consistent way to check/uncheck a group of checkboxes across the application.

I chose to use the version with the green tick because it requires less space than the explicit links and it fits better.
I'm not saying that the green tick is the best option, but this is an ongoing discussion (#27678).

Patch 6 can be applied also on the next minor version if we want to fix the issue from the new member modal earlier.

Some screenshots attached.

0001-adds-toogle-checkboxes-to-activities-tab-from-projec.patch Magnifier (1.13 KB) Marius BALTEANU, 2017-12-16 11:04

0003-adds-toogle-checkboxes-to-project-modules-from-proje.patch Magnifier (1.09 KB) Marius BALTEANU, 2017-12-16 11:04

0002-adds-toogle-checkboxes-to-trackers-and-custom-fields.patch Magnifier (2.22 KB) Marius BALTEANU, 2017-12-16 11:04

0004-adds-toogle-checkboxes-feature-to-roles-permissions.patch Magnifier (1.28 KB) Marius BALTEANU, 2017-12-16 11:04

0005-replace-check_all_links-in-new-tracker-form-with-too.patch Magnifier (1.25 KB) Marius BALTEANU, 2017-12-16 11:04

0006-replace-check_all_links-in-new-custom-field-form-wit.patch Magnifier (2.06 KB) Marius BALTEANU, 2017-12-16 11:04

0007-use-regular-icon-icon-checked-classes.patch Magnifier (1.39 KB) Marius BALTEANU, 2017-12-16 11:04

0008-fix-icon-position-in-new-member-modal.patch Magnifier (1008 Bytes) Marius BALTEANU, 2017-12-16 11:04

Screen Shot 2017-12-16 at 12.04.52.png (78.6 KB) Marius BALTEANU, 2017-12-16 11:08

Screen Shot 2017-12-16 at 12.05.07.png (83.5 KB) Marius BALTEANU, 2017-12-16 11:08

Screen Shot 2017-12-16 at 12.05.33.png (51.3 KB) Marius BALTEANU, 2017-12-16 11:08

Screen Shot 2017-12-16 at 12.05.42.png (53 KB) Marius BALTEANU, 2017-12-16 11:08

Screen Shot 2017-12-16 at 12.05.54.png (74.2 KB) Marius BALTEANU, 2017-12-16 11:08


Related issues

Related to Redmine - Patch #27678: Make "Check all / Uncheck all" link noticeable New

History

#1 Updated by Marius BALTEANU about 1 month ago

  • Tracker changed from Defect to Patch

#3 Updated by Marius BALTEANU about 1 month ago

  • Related to Patch #27678: Make "Check all / Uncheck all" link noticeable added

#4 Updated by Mizuki ISHIKAWA 12 days ago

+1
I think that this change will improve usability.

Also available in: Atom PDF