Defect #28409

Total estimated time value not visible when tracker has estimate time field disabled

Added by Sebastian Paluch almost 3 years ago. Updated about 1 month ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Issues
Target version:Candidate for next major release
Resolution: Affected version:3.4.4

Description

There is a tracker that does have estimate time field disabled. The issue of that tracker can have subtasks of different trackers that do have estimated time. The estiamted time for the parent issue is not shown at all, it should show total estimated time, in brackets. This works fine for spend time.

before@2x.png (27.1 KB) Go MAEDA, 2018-04-03 04:35

after@2x.png (29.2 KB) Go MAEDA, 2018-04-03 04:35

tests.patch Magnifier (1.18 KB) Tomomi Yuzuriha, 2018-05-28 07:07

History

#1 Updated by Go MAEDA almost 3 years ago

I agree with Sebastian Paluch. Here is a patch without tests.

Index: app/views/issues/show.html.erb
===================================================================
--- app/views/issues/show.html.erb    (revision 17253)
+++ app/views/issues/show.html.erb    (working copy)
@@ -64,7 +64,7 @@
   unless @issue.disabled_core_fields.include?('done_ratio')
     rows.right l(:field_done_ratio), progress_bar(@issue.done_ratio, :legend => "#{@issue.done_ratio}%"), :class => 'progress'
   end
-  unless @issue.disabled_core_fields.include?('estimated_hours')
+  unless @issue.disabled_core_fields.include?('estimated_hours') && @issue.total_estimated_hours.blank?
     rows.right l(:field_estimated_hours), issue_estimated_hours_details(@issue), :class => 'estimated-hours'
   end
   if User.current.allowed_to?(:view_time_entries, @project) && @issue.total_spent_hours > 0

Before:

After:

#2 Updated by Go MAEDA over 2 years ago

  • Target version set to Candidate for next minor release

#3 Updated by Tomomi Yuzuriha over 2 years ago

I've added the test-code for Go MAEDA's patch(#28409-1).

#4 Updated by Sebastian Paluch 8 months ago

Any chance to get this minor thing in soon?

#5 Updated by Go MAEDA 8 months ago

  • Target version changed from Candidate for next minor release to 4.2.0

Setting the target version to 4.2.0.

#6 Updated by Go MAEDA about 1 month ago

  • Target version changed from 4.2.0 to Candidate for next major release

I found a problem in patch #28409#note-1.

Redmine shows estimated hours for a parent task in some cases even if estimated hours is disabled. You can reproduce the problem with the following steps:

1. Set any value to the estimated hours field of a parent task and subtask
2. Disable the estimated hours field for the tracker
3. Open the parent task. The value of the parent task's estimated hour should not be displayed because the field is disabled, but both the parent's estimated hours and total estimated hours are displayed

Also available in: Atom PDF