Project

General

Profile

Actions

Patch #29160

closed

Remove unused and broken method CustomField.visibility_condition

Added by Holger Just over 6 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The class method was introduced in r12012 along with the instance method CustomField#visibility_by_project_condition. The method's body seems to follow the idea of the instance method but misses a lot of data required by it, including the user and the project_key. As such, the method would always throw an exception when called.

Since the method is not tested, is never called by Redmine anywhere, and is unusable anyway, we can simply remove it as done by the attached patch.


Files


Related issues

Related to Redmine - Feature #5037: Role-based issue custom field visibilityClosedJean-Philippe Lang2010-03-10

Actions
Actions #1

Updated by Go MAEDA over 6 years ago

  • Related to Feature #5037: Role-based issue custom field visibility added
Actions #2

Updated by Go MAEDA over 6 years ago

  • Target version changed from Candidate for next minor release to 4.0.0

I have confirmed the problem Holger reported. Setting target version to 4.0.0.

Actions #3

Updated by Jean-Philippe Lang about 6 years ago

  • Status changed from New to Closed
  • Assignee set to Jean-Philippe Lang

Committed, thanks.

Actions

Also available in: Atom PDF