Patch #29308

Time entry creation: preserve 'spent on' value when using 'Create and Continue'

Added by Jens Krämer 4 months ago. Updated 4 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:Time tracking
Target version:3.3.9

Description

When creating a time entry and using the 'Create and continue' button to save and return to the form, the previously entered date is replaced with the current date while issue id and activity are preserved. This patch changes that so the previously entered date is preserved as well.

0001-time-entry-creation-preserve-spent-on-when-using-cre.patch Magnifier (936 Bytes) Jens Krämer, 2018-08-01 07:17

0002-amends-the-timelog_controller_test-to-account-for-sp.patch Magnifier (2.36 KB) Jens Krämer, 2018-08-02 05:18


Related issues

Duplicated by Redmine - Feature #28081: Option to keep last spent-time date on "create and continue" Closed

Associated revisions

Revision 17459
Added by Go MAEDA 4 months ago

Time entry creation: preserve 'spent on' value when using 'Create and Continue' (#29308).

Patch by Jens Krämer.

Revision 17460
Added by Go MAEDA 4 months ago

Merged r17459 from trunk to 3.4-stable (#29308).

Revision 17461
Added by Go MAEDA 4 months ago

Merged r17459 from trunk to 3.3-stable (#29308).

History

#1 Updated by Go MAEDA 4 months ago

  • Target version set to 3.3.9

I think it is very natural to preserve date and there is no reason not to do so. Probably most users expect the proposed behavior. Setting target version to 3.3.9.

#2 Updated by Marius BALTEANU 4 months ago

Go MAEDA wrote:

I think it is very natural to preserve date and there is no reason not to do so. Probably most users expect the proposed behavior. Setting target version to 3.3.9.

Indeed.

+1

#3 Updated by Go MAEDA 4 months ago

  • Assignee set to Jens Krämer

The patch breaks some tests. Would you update the tests?

#4 Updated by Jens Krämer 4 months ago

my bad, please find attached a second patch that fixes those.

#5 Updated by Go MAEDA 4 months ago

  • Assignee changed from Jens Krämer to Go MAEDA

Great, everything is fine now. Thanks.

#6 Updated by Go MAEDA 4 months ago

  • Status changed from New to Resolved

#7 Updated by Go MAEDA 4 months ago

  • Status changed from Resolved to Closed

Committed. Thank you for sharing the improvement.

#8 Updated by Marius BALTEANU 4 months ago

  • Duplicated by Feature #28081: Option to keep last spent-time date on "create and continue" added

Also available in: Atom PDF