Projects API should not return invisible trackers
|Assignee:||Go MAEDA||% Done:|
Currently projects API returns all trackers, assigned to given project. This is inconsistency with web view, which shows only trackers, visible to the user. They are the only usable to current user anyways.
This is invoked like this: projects/PROJECTID.json?include=trackers
The problem is in redmine/app/helpers/projects_helper.rb, where the line:
project.trackers.each do |tracker|
should be changed to
project.trackers.visible.each do |tracker|
#4 Updated by Yuichi HARADA about 2 years ago
Alex Stanev wrote:
should be changed toproject.trackers.visible.each do |tracker|
I think that
project.rolled_up_trackers(false).visible is better than
I changed it as follows.
diff --git a/app/helpers/projects_helper.rb b/app/helpers/projects_helper.rb index 794546163..64d6fea83 100644 --- a/app/helpers/projects_helper.rb +++ b/app/helpers/projects_helper.rb @@ -115,7 +115,7 @@ module ProjectsHelper def render_api_includes(project, api) api.array :trackers do - project.trackers.each do |tracker| + project.rolled_up_trackers(false).visible.each do |tracker| api.tracker(:id => tracker.id, :name => tracker.name) end end if include_in_api_response?('trackers')
I made a patch, and attach it.
LGTM. We (matobaa, sanak and me) have verified the following with trunk (revision 20744).
- The bug reported in the issue has been fixed by your patch.
- All tests are also successful.
In the patch, we noticed that the argument of
false instead of
Setting.display_subprojects_issues? as in
ProjectsController#show. We assume this is because the sub project trackers are probably not needed with this API.