Redmine

Since Redmine 6.0.0 started using Tabler Icons (#23980), the following icon would currently be a candidate for the new "Quote" icon.
https://tabler.io/icons/icon/quote

Looks good. However, the following system test has been failing since commit r23809:
https://github.com/redmine/redmine/actions/runs/15354807677/job/43211407573#step:5:33

Failure:
ReactionsSystemTest#test_reaction_button_is_visible_on_property_changes_tab [test/system/reactions_test.rb:146]:
expected to find css "a.icon-comment" within #<Capybara::Node::Element tag="div" path="/HTML/BODY[1]/DIV[1]/DIV[4]/DIV[2]/DIV[3]/DIV[2]/DIV[1]"> but there were no matches

bin/rails test test/system/reactions_test.rb:116

Here's the fix:

diff --git a/test/system/reactions_test.rb b/test/system/reactions_test.rb
index cd3e2e871..96dd4cf81 100644
--- a/test/system/reactions_test.rb
+++ b/test/system/reactions_test.rb
@@ -129,7 +129,7 @@ class ReactionsSystemTest < ApplicationSystemTestCase
     within('#change-1') do
       assert_selector 'a.reaction-button'

-      assert_no_selector 'a.icon-comment'
+      assert_no_selector 'a.icon-quote'
       assert_no_selector 'span.drdn'
     end
     within("#change-#{journal_without_notes.id}") do
@@ -143,14 +143,14 @@ class ReactionsSystemTest < ApplicationSystemTestCase
     within('#change-1') do
       assert_selector 'a.reaction-button'

-      assert_selector 'a.icon-comment'
+      assert_selector 'a.icon-quote'
       assert_selector 'span.drdn'
     end
     within("#change-#{journal_without_notes.id}") do
       assert_selector 'a.reaction-button'
       assert_selector 'span.drdn'

-      assert_no_selector 'a.icon-comment'
+      assert_no_selector 'a.icon-quote'
     end
   end

Katsuya HIDAKA wrote in #note-8:

Looks good. However, the following system test has been failing since commit r23809:
https://github.com/redmine/redmine/actions/runs/15354807677/job/43211407573#step:5:33

Committed the fix in r23810. Thank you.

Thanks!