Patch #31640: Add clear query icon next to selected query in sidebar - Redmine

Patch #31640

Add clear query icon next to selected query in sidebar

Added by Marius BALTEANU over 2 years ago. Updated about 2 years ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

Go MAEDA

% Done:

Category:

Target version:

4.1.0

Description

Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.

My proposal is to add a Clear link next to selected query link:

On hover:

clear_query.png (43.4 KB) Marius BALTEANU, 2019-06-29 13:42

clear_query_hover.png (45.2 KB) Marius BALTEANU, 2019-06-29 13:43

0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch (3.64 KB) Marius BALTEANU, 2019-06-29 13:57

clear_with_close.png (41.2 KB) Marius BALTEANU, 2019-07-01 00:07

0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch (3.64 KB) Marius BALTEANU, 2019-07-01 00:09

clear_with_close_hl@2x.png (13.8 KB) Go MAEDA, 2019-09-08 16:30

31640-close_hl.patch (3.77 KB) Go MAEDA, 2019-09-12 04:39

Related issues

Associated revisions

Revision 18468
Added by Go MAEDA about 2 years ago

Add clear query icon next to selected query in sidebar (#31640).

Patch by Marius BALTEANU.

History

#1 Updated by Marius BALTEANU over 2 years ago

File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added

#2 Updated by Marius BALTEANU over 2 years ago

Related to Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown added

#3 Updated by Marius BALTEANU over 2 years ago

File deleted (~~0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch~~)

#4 Updated by Marius BALTEANU over 2 years ago

File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added

Fixed some Rubocop warnings.

#5 Updated by Marius BALTEANU over 2 years ago

All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/68625213

#6 Updated by Go MAEDA over 2 years ago

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

#7 Updated by Marius BALTEANU over 2 years ago

File clear_with_close.png added
File 0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch added

Go MAEDA wrote:

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

Agree, but (close.png) icon is not so visible:

Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.

#8 Updated by Go MAEDA about 2 years ago

File clear_with_close_hl@2x.png added
File 31910.patch added
Target version changed from Candidate for next major release to 4.1.0

Marius BALTEANU wrote:

Agree, but (close.png) icon is not so visible:

Using (close_hl.png) looks nicer.

#9 Updated by Marius BALTEANU about 2 years ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Agree, but (close.png) icon is not so visible:

Using (close_hl.png) looks nicer.

Indeed, close_hl.png is better.

Regarding the patch, you have attached a wrong one.

#10 Updated by Go MAEDA about 2 years ago

File deleted (~~31910.patch~~)

#11 Updated by Go MAEDA about 2 years ago

File 31640-close_hl.patch added