Patch #31640
Add clear query icon next to selected query in sidebar
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | UI | |||
| Target version: | 4.1.0 |
Description
Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.
My proposal is to add a Clear link next to selected query link:
On hover:
clear_query.png (43.4 KB)
clear_query_hover.png (45.2 KB)
0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch 
(3.64 KB)
clear_with_close.png (41.2 KB)
0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch
(3.64 KB)
clear_with_close_hl@2x.png (13.8 KB)
31640-close_hl.patch
(3.77 KB)
Related issues
Associated revisions
Add clear query icon next to selected query in sidebar (#31640).
Patch by Marius BALTEANU.
History
#1
Updated by Marius BALTEANU about 1 year ago
- File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added
#2
Updated by Marius BALTEANU about 1 year ago
- Related to Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown added
#3
Updated by Marius BALTEANU about 1 year ago
- File deleted (
0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch)
#4
Updated by Marius BALTEANU about 1 year ago
Fixed some Rubocop warnings.
#5
Updated by Marius BALTEANU about 1 year ago
All tests pass: https://gitlab.com/redmine-org/redmine/pipelines/68625213
#6
Updated by Go MAEDA about 1 year ago
Although I understand the reason why you use 
(reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to 
(close.png).
#7
Updated by Marius BALTEANU about 1 year ago
- File clear_with_close.png added
- File 0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch added
Go MAEDA wrote:
Although I understand the reason why you use
Agree, but (close.png) icon is not so visible:
Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.
#8
Updated by Go MAEDA 10 months ago
- File clear_with_close_hl@2x.png added
- File 31910.patch added
- Target version changed from Candidate for next major release to 4.1.0
Marius BALTEANU wrote:
Agree, but
Using 
(close_hl.png) looks nicer.
#9
Updated by Marius BALTEANU 10 months ago
Go MAEDA wrote:
Marius BALTEANU wrote:
Agree, but
Using
Indeed, close_hl.png is better.
Regarding the patch, you have attached a wrong one.
#11
Updated by Go MAEDA 10 months ago
- File 31640-close_hl.patch added
Marius BALTEANU wrote:
Regarding the patch, you have attached a wrong one.
Sorry, here is the correct patch.