Project

General

Profile

Actions

Patch #31640

closed

Add clear query icon next to selected query in sidebar

Added by Marius BĂLTEANU almost 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Now that "All issues" link was removed from the sidebar, we should have an easier way in sidebar to clear the current query.

My proposal is to add a Clear link next to selected query link:

On hover:


Files

clear_query.png (43.4 KB) clear_query.png Marius BĂLTEANU, 2019-06-29 13:42
clear_query_hover.png (45.2 KB) clear_query_hover.png Marius BĂLTEANU, 2019-06-29 13:43
0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch (3.64 KB) 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch Marius BĂLTEANU, 2019-06-29 13:57
clear_with_close.png (41.2 KB) clear_with_close.png Marius BĂLTEANU, 2019-07-01 00:07
0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch (3.64 KB) 0001-Add-clear-link-icon-for-selected-query-in-sidebar_2.patch Marius BĂLTEANU, 2019-07-01 00:09
clear_with_close_hl@2x.png (13.8 KB) clear_with_close_hl@2x.png Go MAEDA, 2019-09-08 16:30
31640-close_hl.patch (3.77 KB) 31640-close_hl.patch Go MAEDA, 2019-09-12 04:39

Related issues

Related to Redmine - Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown ClosedJean-Philippe Lang

Actions
Actions #1

Updated by Marius BĂLTEANU almost 5 years ago

  • File 0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch added
Actions #2

Updated by Marius BĂLTEANU almost 5 years ago

  • Related to Patch #30294: Move the links (View all issues, Summary, Import) from the Issues section of the issues list sidebar under a dropdown added
Actions #3

Updated by Marius BĂLTEANU almost 5 years ago

  • File deleted (0001-Add-clear-link-icon-for-selected-query-in-sidebar.patch)
Actions #6

Updated by Go MAEDA almost 5 years ago

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

Actions #7

Updated by Marius BĂLTEANU almost 5 years ago

Go MAEDA wrote:

Although I understand the reason why you use (reload.png), I think the current icon used in your patch is not appropriate because it looks like a button to reload the current query. In my opinion, the icon should be the one similar to (close.png).

Agree, but (close.png) icon is not so visible:

Attached the updated patch. Go Maeda, if you have a better idea, please fell free to update my patch.

Actions #8

Updated by Go MAEDA almost 5 years ago

Marius BALTEANU wrote:

Agree, but (close.png) icon is not so visible:

Using (close_hl.png) looks nicer.

Actions #9

Updated by Marius BĂLTEANU almost 5 years ago

Go MAEDA wrote:

Marius BALTEANU wrote:

Agree, but (close.png) icon is not so visible:

Using (close_hl.png) looks nicer.

Indeed, close_hl.png is better.

Regarding the patch, you have attached a wrong one.

Actions #10

Updated by Go MAEDA almost 5 years ago

  • File deleted (31910.patch)
Actions #11

Updated by Go MAEDA almost 5 years ago

Marius BALTEANU wrote:

Regarding the patch, you have attached a wrong one.

Sorry, here is the correct patch.

Actions #12

Updated by Go MAEDA almost 5 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you for improving Redmine.

Actions

Also available in: Atom PDF