Back url parse in validation
|Target version:||Candidate for next minor release|
for example on issues screen, when you apply filters, it generates an url containing:
Because of this bulk_edit (for instance) is unable to redirect back to this url.
The reason is a function in application_controller.rb - validate_back_url
URI.parse(back_url) is unable to parse the special character mentioned above.
The quicke workaround would be
but i am not sure that is sufficient.
#6 Updated by Mizuki ISHIKAWA almost 2 years ago
Tibinko H wrote:
Oh, ok. Did not see that, I am going to put this isssue to resolved then.
I think this problem has not been solved yet.
Sorry, my comment(#31831#note-1) may have misled you.
In #31552 issue, #31552#note-3 changes were finally committed, not #31552#note-2 changes.
#31552#note-3 changes were a partial fix and does not solve the bulk_edit probrem.
I thought that your suggestion for solving the problem that occurs with bulk_edit is good.
#7 Updated by Go MAEDA almost 2 years ago
- Target version set to Candidate for next minor release
Tibinko H, thank you for reporting this issue.
Here is a diff of your workaround.
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb index 06e2d702c..afbb30f3e 100644 --- a/app/controllers/application_controller.rb +++ b/app/controllers/application_controller.rb @@ -440,7 +440,7 @@ class ApplicationController < ActionController::Base end begin - uri = URI.parse(back_url) + uri = URI.parse(URI.encode(back_url)) rescue URI::InvalidURIError return false end