Actions
Defect #31870
closedRemove deprecated .zIndex() method
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Système : Debian 10
Redmine version : 4.0.1-2
libjs-jquery-ui version : 1.12.1+dfsg-5
.zIndex() method is deprecated from jQuery UI
https://jqueryui.com/upgrade-guide/1.12/#removed-zindex
.zIndex() is used in public/javascript/application.js
https://www.redmine.org/projects/redmine/repository/entry/branches/4.0-stable/public/javascripts/application.js
lines 429, 439
problem occurs when adding member to a project.
proposed correction :
function showModal(id, width, title) {
var el = $('#'+id).first();
if (el.length === 0 || el.is(':visible')) {return;}
if (!title) title = el.find('h3.title').text();
// moves existing modals behind the transparent background
- $(".modal").zIndex(99);
+ $(".modal").css('zIndex',99);
el.dialog({
width: width,
modal: true,
resizable: false,
dialogClass: 'modal',
title: title
}).on('dialogclose', function(){
- $(".modal").zIndex(101);
+ $(".modal").css('zIndex',101);
});
el.find("input[type=text], input[type=submit]").first().focus();
}
Related issues
Updated by Go MAEDA about 6 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA about 6 years ago
- Related to Feature #31196: Updates jQuery to 2.2.4 and adds jQuery Migrate library added
Updated by Marius BĂLTEANU about 6 years ago
- Related to Feature #31887: Update jQuery UI to 1.12.1 added
Updated by Marius BĂLTEANU about 6 years ago
- Related to deleted (Feature #31887: Update jQuery UI to 1.12.1)
Updated by Marius BĂLTEANU about 6 years ago
- Blocks Feature #31887: Update jQuery UI to 1.12.1 added
Updated by Go MAEDA about 6 years ago
- Category changed from Third-party libraries to Code cleanup/refactoring
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version changed from Candidate for next minor release to 4.1.0
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.
Updated by Go MAEDA about 6 years ago
- Subject changed from jQuery / zIndex deprecated to Remove deprecated .zIndex() method
Updated by Go MAEDA about 6 years ago
- Related to Defect #31708: Not able to add member to a project added
Updated by Go MAEDA about 6 years ago
- Target version changed from 4.1.0 to 4.0.5
Updated by Paweł Szmigiel about 6 years ago
Hi, already asked this in Defect #31708, there is a "close" text on the close button, any way to remove it? Appreciate any answer.
Actions