Project

General

Profile

Actions

Feature #31920

closed

Require 2FA only for certain user groups

Added by Jens Krämer almost 5 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Category:
Accounts / authentication
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

This patch, which should be applied on top of those from #1237, adds a flag to groups so 2FA can be globally optional, but required for certain groups of users.


Files


Related issues

Related to Redmine - Feature #35086: Please consider changing the way how 2FA is set upClosed

Actions
Related to Redmine - Feature #35439: Option to require 2FA only for users with administration rightsClosedMarius BĂLTEANU

Actions
Blocked by Redmine - Feature #1237: Add support for two-factor authenticationClosedGo MAEDA2008-05-14

Actions
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Blocked by Feature #1237: Add support for two-factor authentication added
Actions #2

Updated by Marius BĂLTEANU over 3 years ago

  • File 0001-Rebase-patch-from-23653.patch added
  • Subject changed from require 2FA only for certain user groups to Require 2FA only for certain user groups
  • Target version set to 4.2.0

I have rebased this patch in order to deliver this feature together with #1237. All tests pass after I've fixed the rubocop warnings.

Actions #3

Updated by Marius BĂLTEANU about 3 years ago

  • Assignee set to Jean-Philippe Lang
  • Target version changed from 4.2.0 to 5.0.0
Actions #4

Updated by Marius BĂLTEANU about 3 years ago

  • Related to Feature #35086: Please consider changing the way how 2FA is set up added
Actions #5

Updated by Marius BĂLTEANU almost 3 years ago

  • Assignee changed from Jean-Philippe Lang to Marius BĂLTEANU
Actions #6

Updated by Marius BĂLTEANU almost 3 years ago

  • File deleted (0001-Rebase-patch-from-23653.patch)
Actions #7

Updated by Marius BĂLTEANU almost 3 years ago

I've updated the patch for the current trunk and I made two changes:
1. Remove the empty setup do end from test/integration/twofa_test.rb
2. Added a check in app/view/groups/_form.html.erb in order to not diplay the "Require two factor authentication" field for builtin groups (Anonymous and Non Member) because the option won't make any sense for those groups.

Jens Priesen Krämer, please take a look over my changes, I would like to commit this as soon as possible if the changes look good to you.

Actions #8

Updated by Jens Krämer almost 3 years ago

looks good to me!

Actions #9

Updated by Marius BĂLTEANU almost 3 years ago

  • Status changed from New to Resolved

Committed the patch. Thank you for your contribution.

Actions #10

Updated by Marius BĂLTEANU almost 3 years ago

  • Tracker changed from Patch to Feature
  • Status changed from Resolved to Closed
Actions #11

Updated by Holger Just over 2 years ago

  • Related to Feature #35439: Option to require 2FA only for users with administration rights added
Actions

Also available in: Atom PDF