Project

General

Profile

Actions

Patch #32013

closed

Rounded corners of the main menu

Added by Anonymous over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Most UI elements of Redmine are now rounded, it feels like main menu should too.


Files

rounded-main-menu-corners.patch (1021 Bytes) rounded-main-menu-corners.patch Anonymous, 2019-09-04 18:52
roundedmenu.png (20.4 KB) roundedmenu.png Anonymous, 2019-09-04 19:33
menu-children-border-radius.png (5.75 KB) menu-children-border-radius.png Bernhard Rohloff, 2019-09-23 06:51
fixed-menu-children-border-radius.diff (1.51 KB) fixed-menu-children-border-radius.diff Bernhard Rohloff, 2019-09-23 06:51

Related issues

Related to Redmine - Patch #32015: Rounded corners of "my page" blocksClosedGo MAEDA

Actions
Related to Redmine - Patch #32014: Rounded corners on table.list elementsClosedGo MAEDA

Actions
Related to Redmine - Patch #32016: Rounded coreners on roadmap's progress barNew

Actions
Related to Redmine - Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elementsNew

Actions
Actions #1

Updated by Anonymous over 4 years ago

Actions #2

Updated by Bernhard Rohloff over 4 years ago

  • Related to Patch #32015: Rounded corners of "my page" blocks added
Actions #3

Updated by Bernhard Rohloff over 4 years ago

+1 IMHO it looks very nice and polished. It fits nicely into the design of the other tab menus.

Actions #4

Updated by Bernhard Rohloff over 4 years ago

  • Related to Patch #32014: Rounded corners on table.list elements added
Actions #5

Updated by Bernhard Rohloff over 4 years ago

  • Related to Patch #32016: Rounded coreners on roadmap's progress bar added
Actions #6

Updated by Go MAEDA over 4 years ago

  • Target version set to 4.1.0

LGTM. Setting the target version to 4.1.0.

Bernhard Rohloff wrote:

It fits nicely into the design of the other tab menus.

Indeed. Tabs in the project settings page and the administration page already have rounded corner. Tabs in the project menu should have rounded corner as well in order to make the appearance consistent.

Actions #7

Updated by Go MAEDA over 4 years ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you for the nice improvement.

Actions #8

Updated by Bernhard Rohloff over 4 years ago

I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.

Actions #9

Updated by Anonymous over 4 years ago

Bernhard Rohloff wrote:

I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too. I don't think this was intended by Antonio. Attached is a patch to fix it. It also refactors the previous patch as the border radius can be set in one place.

Thanks for the heads up, I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D

I think we should add #32100 as related to this ticket.

Actions #10

Updated by Bernhard Rohloff over 4 years ago

  • Related to Patch #32100: Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements added
Actions #11

Updated by Bernhard Rohloff over 4 years ago

Antonio McDeal wrote:

... I already did a fix to this in #32100 but I guess Bernhard's version of this patch here is a bit better, so I will update the second patch in #32100 to bounce off the new circumstances as well :D

Oh sorry, I didn't noticed that...

I think we should add #32100 as related to this ticket.

done ;-)

Actions #12

Updated by Anonymous over 4 years ago

Go, would it be possible to commit Bernhard's fix? I tested it, works well ;-)

Actions #13

Updated by Go MAEDA over 4 years ago

  • Status changed from Reopened to Closed

Bernhard Rohloff wrote:

I've discovered a little flaw in the patch. It sets the border radius for the items in the dropdown menu, too.

Committed the fix fixed-menu-children-border-radius.diff in r18543. Thanks.

Actions

Also available in: Atom PDF