Patch #32100

Fixed and added roundiness to the "plus" (+) flyout menu and it's child elements

Added by Anonymous 11 months ago. Updated 10 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:UI
Target version:-

Description

This patch is a follow up to #32013 and fixes the look of the "plus" fly-out menu.

plus-menu1.PNG (4.81 KB) Anonymous, 2019-09-20 21:13

plus-menu2.PNG (4.74 KB) Anonymous, 2019-09-20 21:13

plus-menu3.PNG (4.65 KB) Anonymous, 2019-09-20 21:13

fix-roundiness-on-plus-menu.patch Magnifier (1016 Bytes) Anonymous, 2019-09-20 21:14

fix-roundiness-on-plus-menu-without-menuchild-roundiness.patch Magnifier (802 Bytes) Anonymous, 2019-09-21 01:43

plus-flyout-update.patch Magnifier (622 Bytes) Anonymous, 2019-09-26 17:30


Related issues

Related to Redmine - Patch #32013: Rounded corners of the main menu Closed

History

#1 Updated by Anonymous 11 months ago

Alternative, simpler patch which only adds roundness to the bottom of the fly-out menu and removes on-hover roundness from children elements inside it.

#2 Updated by Marius BALTEANU 11 months ago

I like the rounded tabs for the main menu, but I don’t see a real benefit for making also the hover element rounded in the fly-out menu. That menu is more like a select/dropdown.

#3 Updated by Anonymous 11 months ago

Marius BALTEANU wrote:

but I don’t see a real benefit for making also the hover element rounded in the fly-out menu.

Hence why I also added the fix-roundiness-on-plus-menu-without-menuchild-roundiness.patch, in case menu child roundness would seem like a lame idea. I think it should be committed either way, because at least it fixes what's caused in that fly-out menu, by patch #32013 :D
Else it feels kinda a bit inconsistent... because
- Project selector box on the other side is rounded.
- Issue context menu is also rounded.

and this fly-out is not rounded...

#4 Updated by Bernhard Rohloff 11 months ago

  • Related to Patch #32013: Rounded corners of the main menu added

#5 Updated by Anonymous 10 months ago

Due to Bernhard's fix in r18543, I'm attaching the new revision compatible version of this patch.
This patch also adds "hidden overflow" this time, to avoid child element's corners to stick outside, and preserve proper roundness

P.S. I think we should rename this ticket to "added roundness to the bottom of "plus" (+) fly-out menu"

Also available in: Atom PDF