Defect #32194
Calendar page lacks buttons to manage custom queries
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Calendar | |||
| Target version: | 4.2.0 | |||
| Resolution: | Fixed | Affected version: |
Description
You can apply existing custom queries to Calendar but you cannot create, edit, or delete custom queries on the Calendar page because the page lacks "Save", "Edit", or "Delete" buttons for queries.
Like Issues and Gantt, the Calendar page should also have those buttons.
no-save-button@2x.png (29.3 KB)
no-edit-and-delete-buttons@2x.png (25.7 KB)
0001-Add-manage-custom-query-buttons-on-calendar.patch 
(5.95 KB)
0002-Fix-indentation-in-queries-_form.patch
(9.6 KB)
0001-Add-manage-custom-query-buttons-on-calendar.patch
(6.04 KB)
Associated revisions
Add buttons to save/edit/delete a custom query to calendar view (#32194).
Patch by Mizuki ISHIKAWA.
Fix indentation in app/views/queries/_form.html.erb (#32194).
Patch by Mizuki ISHIKAWA.
History
#1
Updated by Mizuki ISHIKAWA 4 months ago
- File 0001-Add-manage-custom-query-buttons-on-calendar.patch added
- File 0002-Fix-indentation-in-queries-_form.patch added
I attach a patch to add "Save", "Edit" and "Delete" buttons(0001~).
The 0002 patch corrects the indentation of corrects app/views/queries/_form.html.erb.
Since the buttons are only added by the 0001 patch, it is not mandatory to commit the 0002 patch.
#3
Updated by Marius BALTEANU 3 months ago
- Target version set to 4.2.0
#5
Updated by Marius BALTEANU 3 months ago
Go MAEDA wrote:
Go MAEDA wrote:
This patch conflicts with #23980. I don't commit this patch now in order to prioritize #23980.
Since #23980 was postponed until 5.0.0, I think this fix can be committed now.
I think the patches conflicts with #29482 and not with #23980. Right now, only the first patch can be applied cleanly on the current trunk.
#7
Updated by Mizuki ISHIKAWA about 1 month ago
- File 0001-Add-manage-custom-query-buttons-on-calendar.patch added
- File 0002-Fix-indentation-in-queries-_form.patch added
I modified the patch so that it can be applied cleanly to the current trunk.
#8
Updated by Go MAEDA about 1 month ago
- Target version changed from Candidate for next major release to 4.2.0
Thank you for updating the patch. Setting the target version to 4.2.0.
#9
Updated by Go MAEDA about 1 month ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.