Actions
Defect #32289
closed
Don't try to generate thumbnails if convert command is not available
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Currently, Redmine always tries to render attachment thumbnails if the setting "Display attachment thumbnails" is enabled even when ImageMagick's convert command is not available. As a result, users may see broken image icons.
I think such broken things should not be displayed. Redmine should not try to generate thumbnails if the command to create thumbnails is not available.
Files
Related issues
Updated by Go MAEDA about 6 years ago
- Blocks Feature #32249: Show attachment thumbnails by default added
Updated by Yuichi HARADA about 6 years ago
- File 32289_not_thumbnailable_when_convert_unavailable.patch 32289_not_thumbnailable_when_convert_unavailable.patch added
The following patch will determine if ImageMagick's convert command is available. I attached a patch.
diff --git a/app/models/attachment.rb b/app/models/attachment.rb
index 8304d4dea..627c1a181 100644
--- a/app/models/attachment.rb
+++ b/app/models/attachment.rb
@@ -201,7 +201,9 @@ class Attachment < ActiveRecord::Base
end
def thumbnailable?
- image? || (is_pdf? && Redmine::Thumbnail.gs_available?)
+ Redmine::Thumbnail.convert_available? && (
+ image? || (is_pdf? && Redmine::Thumbnail.gs_available?)
+ )
end
# Returns the full path the attachment thumbnail, or nil
Updated by Go MAEDA about 6 years ago
- Target version set to Candidate for next major release
Updated by Go MAEDA about 6 years ago
- File 32289-v2.patch 32289-v2.patch added
- Assignee set to Go MAEDA
- Target version changed from Candidate for next major release to 4.1.0
LGTM. Updated the test name.
Setting the target version to 4.1.0.
Updated by Go MAEDA about 6 years ago
- Status changed from New to Closed
- Resolution set to Fixed
Committed the patch.
Actions