Patch #32326
closed
Update it.yml locale
Added by pasquale [:dedalus] over 6 years ago. Updated over 1 year ago.
Description
- added various missing strings;
- reorder strings into the file;
- made some changes to already translated strings for consistency.
Files
Related issues
Updated by pasquale [:dedalus] over 6 years ago
- File 001-it-locale-v0.2.diff 001-it-locale-v0.2.diff added
Adds to previous patch:
- remove trailing whitespaces from my previous patch;
- adds missing string label_show_closed_projects that is missing in config\locale\it.yml in redmine 4.0.5
The new patch attached is a replacement of the previous one (the previous one is now obsolete)
Updated by Go MAEDA over 6 years ago
Thank you for working hard on updating it.yml.
- Do you have a translation file without reordering? Reordering makes it difficult to compare the current and the new translation
- Could you split the patch into a missing translations patch and a changing existing translation patch? I will commit a patch for missing translations quickly but would not commit changes to existing translation because I don't understand Italian and I cannot judge the changes are appropriate
Updated by pasquale [:dedalus] over 6 years ago
- File 002-01-adds-missing-translations.diff 002-01-adds-missing-translations.diff added
- File 002-02-adds missing key-for-label_show_closed_project.diff 002-02-adds missing key-for-label_show_closed_project.diff added
- File 002-03-fix-some-string-capitalization.diff 002-03-fix-some-string-capitalization.diff added
- File 002-04-fix-incomplete-translation-for-notice_successful-keys.diff 002-04-fix-incomplete-translation-for-notice_successful-keys.diff added
- File 002-05-cumulative-patch-to-fix-existing-translations.diff 002-05-cumulative-patch-to-fix-existing-translations.diff added
Go MAEDA wrote:
Here a new set of patches that are a replacement of previous ones:Thank you for working hard on updating it.yml.
- Do you have a translation file without reordering? Reordering makes it difficult to compare the current and the new translation
- Could you split the patch into a missing translations patch and a changing existing translation patch? I will commit a patch for missing translations quickly but would not commit changes to existing translation because I don't understand Italian and I cannot judge the changes are appropriate
- 002-01-adds-missing-translations.diff adds some missing translation
- attachment:002-02-adds missing key-for-label_show_closed_project.diff adds missing key (and related it string) label_show_closed_project tha was missing in it.yml and it is present in en.yml;
- 002-03-fix-some-string-capitalization.diff fix some capitalizations issue between en.yml and it.yml;
- 002-04-fix-incomplete-translation-for-notice_successful-keys.diff fix incomplete text for 4 notice_successful items;
002-05-cumulative-patch-to-fix-existing-translations.diff changes some strings already existing in previous redmine locale version.
Thanks in advance.
Updated by Go MAEDA over 6 years ago
Thank you for splitting the patch. It is really helpful for me.
I looked 002-01-adds-missing-translations.diff and found that the translation for label_relations is "Relationi", but other existing translation for "relation" is "Relazioni". Is "Relationi" correct?
label_relations: Relationi
Updated by pasquale [:dedalus] over 6 years ago
Go MAEDA wrote:
Is "Relationi" correct?
No, sorry it is a typo error: the right word Is "Relazioni"
Updated by Go MAEDA over 6 years ago
- Related to Defect #32354: Fix inconsistent capitalization in Italian translation added
Updated by Go MAEDA over 6 years ago
I have just opened #32354 to handle the patch 002-03-fix-some-string-capitalization.diff.
Updated by pasquale [:dedalus] over 6 years ago
Hi Go MAEDA, thanks for reviewing my patches.
Maybe a clarification is needed: the patchattachment:"002-02-adds missing key-for-label_show_closed_project.diff" fix an issue on the official it.yml file where the line related at the key label_show_closed_project is missing, so the string "View closed projects" cannot be translate at all.
Thanks!
Updated by Go MAEDA over 6 years ago
pasquale [:dedalus] wrote:
Maybe a clarification is needed: the patchattachment:"002-02-adds missing key-for-label_show_closed_project.diff" fix an issue on the official it.yml file where the line related at the key label_show_closed_project is missing, so the string "View closed projects" cannot be translate at all.
The latest trunk no longer uses label_show_closed_project, so the key has been removed in r18785 (#29482).
Updated by pasquale [:dedalus] over 6 years ago
Updated by Go MAEDA over 6 years ago
- Related to Patch #32358: Fix incomplete Italian translation for notice_successful keys added
Updated by Go MAEDA over 6 years ago
- Status changed from New to Needs feedback
- Assignee set to pasquale [:dedalus]
Hello pasquale [:dedalus], your translation patch (002-05-cumulative-patch-to-fix-existing-translations.diff) changes the Italian words "notizia" and "sottoattività" to English word "news" and "subtask". Could you clarify the reason?
Updated by pasquale [:dedalus] over 6 years ago
Go MAEDA wrote:
Hello pasquale [:dedalus], your translation patch (002-05-cumulative-patch-to-fix-existing-translations.diff) changes the Italian words "notizia" and "sottoattività" to English word "news" and "subtask". Could you clarify the reason?
For news instead of literal translation notizia, because in current language the english word is used and the literal translation is used rarely (xref http://www.treccani.it/vocabolario/news/)
For subtask instead of literal translation sottoattività, because I believe that the english term is more appropriate in a agile context because in current language we refer to task\subtask and not to attività\sottoattività (xref http://www.treccani.it/vocabolario/task/)
Updated by Go MAEDA over 6 years ago
- Related to Patch #32380: Change Italian translation for "news" added
Updated by Go MAEDA over 1 year ago
- Status changed from Needs feedback to Closed
Italian translation for Redmine 5.1 was completed by #41420 and your other patches.
I am closing this issue. Thank you.