Patch #32921
Rails 6: add header=present to csv tests
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | - | |||
| Target version: | 5.0.0 |
Description
fixes
Failure: IssuesControllerTest#test_index_csv_with_all_columns [/redmine/test/functional/issues_controller_test.rb:878]: Expected: "text/csv" Actual: "text/csv; header=present"
csvheaders.patch 
(8.12 KB)
csvheaders2.patch
- reverts test_index_send_nothing_if_query_is_invalid
(7.9 KB)
0001-Rails-6-add-header-present-to-csv-tests.patch
(9.39 KB)
Related issues
History
#1
Updated by Pavel Rosický 27 days ago
- File csvheaders2.patch added
#2
Updated by Marius BALTEANU 27 days ago
- Related to Feature #29914: Migrate to Rails 6 added
#3
Updated by Marius BALTEANU 26 days ago
Pavel, maybe you have a clue because I can't find or understand why media_type returns "text/csv; header=present" and not only text/csv as is explained here.
#4
Updated by Pavel Rosický 26 days ago
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
#5
Updated by Marius BALTEANU 26 days ago
- File 0001-Rails-6-add-header-present-to-csv-tests.patch added
- Target version set to 5.0.0
Pavel Rosický wrote:
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.