Actions
Defect #32921
closed
Rails 6: add header=present to csv tests
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
fixes
Failure: IssuesControllerTest#test_index_csv_with_all_columns [/redmine/test/functional/issues_controller_test.rb:878]: Expected: "text/csv" Actual: "text/csv; header=present"
Files
Related issues
Updated by Pavel Rosický about 4 years ago
- File csvheaders2.patch csvheaders2.patch added
Updated by Marius BĂLTEANU about 4 years ago
- Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Updated by Marius BĂLTEANU about 4 years ago
Pavel, maybe you have a clue because I can't find or understand why media_type returns "text/csv; header=present" and not only text/csv as is explained here.
Updated by Pavel Rosický about 4 years ago
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Updated by Marius BĂLTEANU about 4 years ago
- File 0001-Rails-6-add-header-present-to-csv-tests.patch 0001-Rails-6-add-header-present-to-csv-tests.patch added
- Target version set to 5.0.0
Pavel Rosický wrote:
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.
Updated by Marius BĂLTEANU about 3 years ago
- Tracker changed from Patch to Defect
Updated by Go MAEDA about 3 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch as a part of #29914.
Actions