Actions
Defect #32921
closedRails 6: add header=present to csv tests
Defect #32921:
Rails 6: add header=present to csv tests
Resolution:
Fixed
Affected version:
Description
Files
Actions
Added by Pavel Rosický almost 7 years ago. Updated over 5 years ago.
Description
Files
| csvheaders.patch (8.12 KB) csvheaders.patch | Pavel Rosický, 2020-01-29 23:06 | ||
| csvheaders2.patch (7.9 KB) csvheaders2.patch | reverts test_index_send_nothing_if_query_is_invalid | Pavel Rosický, 2020-01-29 23:12 | |
| 0001-Rails-6-add-header-present-to-csv-tests.patch (9.39 KB) 0001-Rails-6-add-header-present-to-csv-tests.patch | Marius BĂLTEANU, 2020-01-31 14:54 |
Pavel, maybe you have a clue because I can't find or understand why media_type returns "text/csv; header=present" and not only text/csv as is explained here.
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Pavel Rosický wrote:
yeah, because the documentation is obsolete, it was changed here https://github.com/rails/rails/pull/37017
Thanks, it's clear now. Your patches look good to me and the failing tests because of this are passing now. I'm attaching a merged version of your patches.
Committed the patch as a part of #29914.