Project

General

Profile

Actions

Patch #33337

closed

Clean-up workflows controller

Added by Vincent Robert almost 4 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Hello

Here is a patch which aims to refactor the WorkflowsController.
The patch does not change the behavior of the application, but use smaller methods and clearer code. The routes are also updated.

My goal was to use a specific action for each route, and do not use a same method for different purposes (so avoid checking if the request-method is "post" inside actions).

Hope this may help.


Files

cleanup_workflows_controller.diff (17.1 KB) cleanup_workflows_controller.diff Vincent Robert, 2020-04-21 21:10
0002-Fix-route-name.patch (868 Bytes) 0002-Fix-route-name.patch Marius BĂLTEANU, 2021-04-04 13:14
0001-Clean-up-workflows-controller.patch (17.4 KB) 0001-Clean-up-workflows-controller.patch Marius BĂLTEANU, 2021-04-04 13:14
Actions

Also available in: Atom PDF