Defect #33576
closed
Done ratio of a parent issue may be shown as 99% even though all subtasks are completed
0%
Description
Due to a rounding error at source:tags/4.1.1/app/models/issue.rb#L1717, a parent task may show 99% done even when all subtasks are 100% done.
irb(main):001:0> 1610 / 16.1 => 99.99999999999999
Steps to reproduce:
1. Set "% Done" setting (Administration > Settings > Issue tracking) to "Calculated from subtasks"
2. Create a parent task.
3. Create a subtask 1 with 10.0 estimated hours and 100% done ratio
4. Create a subtask 2 with 6.1 estimated hours and 100% done ratio
5. Now the done ratio of the parent task shows 99% instead of 100%
Files
Related issues
Updated by Go MAEDA almost 4 years ago
- Related to Defect #27848: The progress exceeding 99.5% is displayed as 100% added
Updated by Go MAEDA almost 4 years ago
- File fix-33576.patch fix-33576.patch added
- Target version set to Candidate for next minor release
Attaching a patch that fixes the issue.
Updated by Go MAEDA almost 4 years ago
- File fix-33576-v2.patch fix-33576-v2.patch added
Updated the patch not to use Float in the calculation process of a derived done ratio.
Updated by Anonymous
Updated by Go MAEDA almost 4 years ago
- Target version changed from Candidate for next minor release to 4.0.8
Setting the target version to 4.0.8.
Updated by Go MAEDA almost 4 years ago
- Subject changed from Parent task may show 99% done even when all subtasks are 100% done to Done ratio of a parent issue may be shown as 99% even though all subtasks are completed
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch.
Updated by Sebastian Paluch almost 4 years ago
There are also other issues in Done ration calculation #21449
Updated by Go MAEDA almost 2 years ago
- Related to Defect #37151: The done ratio of a parent issue may not be 100% even if all subtasks have a done ratio of 100% added