Defect #33953
Repository tab is not displayed if no repository is set as the main repository
| Status: | Reopened | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | SCM | |||
| Target version: | 5.0.3 | |||
| Resolution: | Fixed | Affected version: | 4.1.1 |
Description
I suggest that:
- if there are any repositories in project, the "Repository Tab" button should show on main menu.
- if no repository is set with "Main repository" and there is only one repository, the page should show the only repository by default.
- if no repository is set with "Main repository" and there is multiple repositories, a blank page with Repositories sidebar should show.
fixed-33953.patch 
(4.09 KB)
Related issues
Associated revisions
Repository tab is not displayed if no repository is set as the main repository (#33953).
Patch by Yuichi HARADA.
Skip test_show_without_main_repository_should_display_first_repository when Subversion test repository is not configured (#33953).
History
#1
Updated by Go MAEDA about 2 years ago
- Category changed from UI to SCM
- Status changed from New to Confirmed
#2
Updated by Go MAEDA about 2 years ago
- Related to Defect #14506: Multiple repositories not visible if main repository is empty added
#3
Updated by Yuichi HARADA almost 2 years ago
- File fixed-33953.patch added
This issue and #14506 need to be resolved together. I created the following patch.
diff --git a/app/controllers/repositories_controller.rb b/app/controllers/repositories_controller.rb
index b0108d531..4ceeaf014 100644
--- a/app/controllers/repositories_controller.rb
+++ b/app/controllers/repositories_controller.rb
@@ -321,7 +321,7 @@ class RepositoriesController < ApplicationController
if params[:repository_id].present?
@repository = @project.repositories.find_by_identifier_param(params[:repository_id])
else
- @repository = @project.repository
+ @repository = @project.repository || @project.repositories.first
end
(render_404; return false) unless @repository
@path = params[:path].is_a?(Array) ? params[:path].join('/') : params[:path].to_s
diff --git a/lib/redmine.rb b/lib/redmine.rb
index de2993e13..470b5ae41 100644
--- a/lib/redmine.rb
+++ b/lib/redmine.rb
@@ -346,7 +346,7 @@ Redmine::MenuManager.map :project_menu do |menu|
menu.push :repository,
{:controller => 'repositories', :action => 'show',
:repository_id => nil, :path => nil, :rev => nil},
- :if => Proc.new {|p| p.repository && !p.repository.new_record?}
+ :if => Proc.new {|p| p.repositories.any?{|r| !r.new_record?}}
menu.push :settings, {:controller => 'projects', :action => 'settings'},
:last => true
end
#4
Updated by Go MAEDA almost 2 years ago
- Target version set to Candidate for next major release
#6
Updated by Go MAEDA about 1 month ago
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Target version changed from 5.1.0 to 5.0.3
- Resolution set to Fixed
Committed the fix. Thank you for your contribution.
#7
Updated by Go MAEDA about 1 month ago
- Subject changed from Repository Tab will not showing if no repository is set as "Main repository" to Repository tab is not displayed if no repository is set as the main repository
#8
Updated by Go MAEDA about 1 month ago
- Status changed from Resolved to Closed
#9
Updated by Marius BALTEANU 10 days ago
- Status changed from Closed to Reopened
There is a failing test: https://www.redmine.org/builds/logs/build_trunk_postgresql_ruby-3.0_2004.html