Cleanups and fixes after Wiki tab removal from project settings (#26579)
This is a series of patches that includes cleanups, fixes and improvements after the Wiki tab was removed from the project settings per #26579:
- 1. Remove '
edit' action from
:manage_wiki permissiondefinition in
Wikis#editis removed by r17018.
- 2. Redirect_to
- 3. Set
This action is executed inside the project wiki scope after r16916, thus we can better set the
- 4. Disable the wiki module after deletion of a project wiki.
By adding a (private)
:disable_wiki_modulecallback that disables the wiki module after deletion of a project wiki, we prevent the need to explicitly have to disable the wiki module first, before (re-)enabling the module would eventually create a new project wiki and reset the
- This fixes issue #34634.
- 5. Changed wiki
:start_pagename to I18n'ed
This prevents a default 'projectid/wiki/Wiki' URL for the project wiki start page.
The test assertion is updated to reflect this change and the containing test is adjusted to handle the i18n'ed text. Code formatting is adjusted whenever code was touched anyways.
This patch series, against source:/trunk@20729, is produced using
git format-patch which makes it apply-able using "
patch -p1 < 0001-...".
Environment: Redmine version 4.1.1.devel@r20729 Ruby version 2.5.8-p224 (2020-03-31) [x64-mingw32] Rails version 184.108.40.206 Environment production Database adapter Mysql2 Mailer queue ActiveJob::QueueAdapters::AsyncAdapter Mailer delivery test SCM: Git 2.26.0 Filesystem Redmine plugins: no plugin installed
Thank you for posting the patch. I have tried out the patches and confirmed the first four patches fix existing issues.
However, I am afraid the change by attachment:0005-Changed-wiki-start_page-name-to-I18n-ed-field_start_.patch is sometimes confusing. Assume the following situation.
1. Create the first Wiki page on a project. The page title will be "Start page"
2. Create a new page with the title "Foo"
3. Set the page "Foo" as a start page
Even after changing the start page to "Foo", the first page's title is still "Start page" despite the page is no longer a start page. Despite a page with the name "Start page" exists, the link "Start page" in the sidebar points to "Foo" page instead of "Start page". I think it is confusing.
#5 Updated by Mischa The Evil 3 months ago
- Subject changed from Cleanups, fixes and improvements after Wiki tab removal from project settings (#26579) to Cleanups and fixes after Wiki tab removal from project settings (#26579)
Go MAEDA wrote:
How about committing the first four patches first, and discussing the fifth patch as a separate issue?
Sorry for the delayed response. I agree with you. I should have separated them in the first place as their changes are unrelated. FWIW: I'd also be ok with dropping the fifth patch altogether early at the gate, given the possible confusion and the severity of the "issue".