Project

General

Profile

Actions
Copy link

Defect #36394

closed

Avoid passing ActionController::Parameters outside of MailHandlerController

Added by Felix Schäfer over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
Code cleanup/refactoring
Target version:
5.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
4.2.3

Description

Currently the MailHandlerController passes an instance of ActionController::Parameters to the MailHandler. The options holds a duplicate ActionController::Parameters of the Controller params.

This can cause difficulties in later processing. We propose explicitly permit-ing the params that will be used later and using a Hash for the options.

Files

Download all files
36394-mail_handler_controller_permit_parameters.patch (979 Bytes) 36394-mail_handler_controller_permit_parameters.patch Felix Schäfer, 2022-01-06 17:03
36394-mail_handler_controller_permit_parameters-v2.patch (1.77 KB) 36394-mail_handler_controller_permit_parameters-v2.patch Go MAEDA, 2022-01-17 02:49
Actions
Copy link

Also available in: Atom PDF