Defect #36561

Wiki revision page does not return 404 if revision does not exist

Added by . ¦3<RELATIVISM . 10 months ago. Updated 9 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Wiki
Target version:4.1.6
Resolution:Fixed Affected version:4.2.3

Description

BUG discovered in wiki revision paths

So like this page only has one revision https://redmine.replicant.us/projects/replicant-infrastructure/wiki/FilteringSpamOnTheMailingList/1
but https://redmine.replicant.us/projects/replicant-infrastructure/wiki/FilteringSpamOnTheMailingList/73 still loads

this can be done with all articles revision pages not just this one.

It is not possible with negative numbers though

defect-36561.patch Magnifier (1.94 KB) Mizuki ISHIKAWA, 2022-02-14 09:01

Associated revisions

Revision 21413
Added by Marius BALTEANU 9 months ago

Return 404 if revision URL doesn't exist (#36561).

Patch by Mizuki ISHIKAWA.

Revision 21418
Added by Marius BALTEANU 9 months ago

Merged r21413 to 4.2-stable (#36561).

Revision 21419
Added by Marius BALTEANU 9 months ago

Merged r21413 to 4.1-stable (#36561).

History

#1 Updated by Marius BALTEANU 10 months ago

  • Status changed from New to Confirmed

#2 Updated by Holger Just 10 months ago

  • Subject changed from BUG with revision urls to Bug with revision URLs of wiki pages

#3 Updated by Mizuki ISHIKAWA 10 months ago

I attached a patch to return 404 when a non-existent revision number is specified.

404: The page you were trying to access doesn't exist or has been removed.

#4 Updated by . ¦3<RELATIVISM . 10 months ago

that is great thanks! I will test in our instance if possible

#5 Updated by Marius BALTEANU 9 months ago

  • Assignee set to Marius BALTEANU
  • Target version set to 4.1.6

#6 Updated by Marius BALTEANU 9 months ago

  • Status changed from Confirmed to Resolved
  • Resolution set to Fixed

Fix committed, thanks!

#7 Updated by Marius BALTEANU 9 months ago

  • Subject changed from Bug with revision URLs of wiki pages to Wiki revision page does not return 404 if revision does not exist
  • Status changed from Resolved to Closed

Also available in: Atom PDF