Defect #36593

User without permissions to view required project custom fields cannot create new projects

Added by Yazan Al aeddin 6 months ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Projects
Target version:4.1.7
Resolution:Fixed Affected version:

Description

Hello
On a project when a custom field is marked as mandatory but not visible for certain roles, users of these roles can no longer create a project.
https://github.com/redmine/redmine/pull/135

redmine.PNG (110 KB) Yazan Al aeddin, 2022-02-09 14:36

Associated revisions

Revision 21488
Added by Marius BALTEANU 5 months ago

Skip validation of required custom fields when creating a project if user does not have permissions to see those custom fields (#36593).

Patch by mathieu-mbru.

Revision 21489
Added by Marius BALTEANU 5 months ago

Revert undesired changes (#36593)

Revision 21491
Added by Marius BALTEANU 5 months ago

Merged r21488 and r21489 to 4.2-stable (#36593).

Revision 21492
Added by Marius BALTEANU 5 months ago

Merged r21488 and r21489 to 4.1-stable (#36593).

History

#1 Updated by Mizuki ISHIKAWA 6 months ago

+1
Thanks for reporting the problem and for sharing the code.

I was able to reproduce the problem.
Here are the steps to reproduce the problem.

  • bundle exec rake db:fixtures:load
  • Log in as admin user
  • Custom fields » Projects » New custom field
    • ✓ required
    • ✓ to these roles only: Manager
  • Log in as jsmith user
  • New project => save
  • The error message "Test cannot be blank" is displayed.

In https://github.com/redmine/redmine/pull/135 , a pull request is proposed to skip the validation of required custom fields when a user who does not have permission to see them tries to create a project.
The same mechanism is already implemented in Issue, so I think it's good to add this pull request code to Redmine.
Issue: https://github.com/redmine/redmine/blob/eb868ad9324e65942e8ad0ccd0a035d801a93864/app/models/issue.rb#L833

#2 Updated by Vincent Robert 5 months ago

  • Category set to Projects
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release

#3 Updated by Marius BALTEANU 5 months ago

  • Assignee set to Marius BALTEANU

#4 Updated by Marius BALTEANU 5 months ago

  • Subject changed from unexpected behavior when a user create a project with required custom field to Unexpected behavior when a user create a project with required custom field
  • Target version changed from Candidate for next minor release to 4.1.7

#5 Updated by Marius BALTEANU 5 months ago

  • Status changed from Confirmed to Resolved

Fix committed, thanks!

#6 Updated by Marius BALTEANU 5 months ago

  • Subject changed from Unexpected behavior when a user create a project with required custom field to User without permissions to view required project custom fields cannot create new projects
  • Status changed from Resolved to Closed
  • Resolution set to Fixed

Also available in: Atom PDF