Patch #36807

Remove CommonMark experimental flag and mark as deprecated the RedCarpet Markdown

Added by Marius BALTEANU 7 months ago. Updated 1 day ago.

Status:ResolvedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Text formatting
Target version:5.1.0

Related issues

Related to Redmine - Feature #32424: CommonMark Markdown Text Formatting Closed
Blocks Redmine - Feature #34863: Change default text formatter for new installations from ... Resolved

Associated revisions

Revision 21594
Added by Marius BALTEANU 5 months ago

Remove experimental flag from CommonMark text formatter (#36807).

Revision 21595
Added by Marius BALTEANU 5 months ago

Revert unwanted change (#36807).

Revision 21898
Added by Marius BALTEANU 1 day ago

Mark legacy Markdown text formatting option as deprecated (#36807).

History

#1 Updated by Marius BALTEANU 7 months ago

  • Related to Feature #32424: CommonMark Markdown Text Formatting added

#2 Updated by Marius BALTEANU 6 months ago

  • Target version changed from Candidate for next major release to 5.1.0

#3 Updated by Go MAEDA 6 months ago

  • Blocks Feature #34863: Change default text formatter for new installations from textile to common_mark added

#4 Updated by Go MAEDA 4 months ago

  • Category set to Text formatting

#5 Updated by Holger Just 4 months ago

For what it's worth, I'm in favor of

  • Removing the experimental flag on the common_mark formatter
  • Marking the previous markdown formatter as deprecated
  • Making the common_mark formatter the default for new installations #34863

The timeline of this may be stretched out a bit, but does not necessarily have to. The deprecation / experimental "flags" on the formatters do not change anything in terms of functionality and can be set in a 5.0.x patch release.

The default formatter is only relevant for new installations. I have no strong opinion on whether this requires a major release (6.0.0) or minor release (5.1.0). I have a slight hunch that it might be surprising in a patch release (5.0.x).

#6 Updated by Marius BALTEANU 3 months ago

I think we do all these changes in 5.1.0.

The experimental flag was already removed in r21594 and I will deprecate markdown right after we switch the default formatter to common_mark (#34863).

#7 Updated by Marius BALTEANU 1 day ago

  • Status changed from New to Resolved

I'va marked in r21898 the legacy Markdown as deprecated, but I think we should show this deprecation also in admin/info for those instances that are using this option.

What do you think?

Also available in: Atom PDF