Defect #36901

Jump to project is misaligned in Safari 15.4 and later

Added by Vitaly vit9696 6 months ago. Updated 5 days ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Go MAEDA% Done:

0%

Category:UI
Target version:4.2.8
Resolution:Fixed Affected version:4.2.5

Description

Jump to project dropdown item is misaligned from the project filter field by 1 pixel down as shown on the screenshot. Tested on Safari 15.4 (17613.1.17.1.13).

Screenshot 2022-04-06 at 15.09.20.png (9.35 KB) Vitaly vit9696, 2022-04-06 14:11

36901.patch Magnifier (2.21 KB) Go MAEDA, 2022-04-16 05:46

Screenshot 2022-04-21 at 21.40.28.png (10.2 KB) Vitaly vit9696, 2022-04-21 20:41

quick-search.diff Magnifier (785 Bytes) Vitaly vit9696, 2022-04-30 13:41

Associated revisions

Revision 21876
Added by Go MAEDA 5 days ago

Jump to project is misaligned in Safari 15.4 and later (#36901).

Patch by Vitaly vit9696.

Revision 21877
Added by Go MAEDA 5 days ago

Merged r21876 from trunk to 5.0-stable (#36901).

Revision 21878
Added by Go MAEDA 5 days ago

Merged r21876 from trunk to 4.2-stable (#36901).

History

#1 Updated by Go MAEDA 6 months ago

  • Subject changed from Jump to project is misaligned to Jump to project is misaligned in Safari 15.4
  • Status changed from New to Confirmed
  • Affected version changed from 5.0.0 to 4.2.5

I have confirmed the issue after updating Safari from 15.3 to 15.4.

#2 Updated by Mizuki ISHIKAWA 6 months ago

Adding the following CSS seems to fix it.

#quick-search form { display: inline-block; }

#3 Updated by Go MAEDA 6 months ago

  • Target version set to 4.2.6

Setting the target version to 4.2.6.

#4 Updated by Go MAEDA 6 months ago

#5 Updated by Vitaly vit9696 6 months ago

This fix is not sufficient, as it results in the dropdown item moving 1 pixel upwards after a click.

#6 Updated by Vitaly vit9696 5 months ago

The attached change looks good to me so far with redmine 5.0.0 on Safari 15.4, Firefox 99.0.1, Chromium 100.0.4896.127.

#7 Updated by Marius BALTEANU 5 months ago

  • Target version changed from 4.2.6 to 4.2.7

#8 Updated by Vitaly vit9696 5 months ago

Marius, could you please clarify why the attached fix was not committed? Thanks!

#9 Updated by Marius BALTEANU 5 months ago

Vitaly vit9696 wrote:

Marius, could you please clarify why the attached fix was not committed? Thanks!

The patch was not tested by me or other Redmine maintainer and it was more important to release the new versions because of the security issues. We will do our best to include the fixes in 4.2.7.

#10 Updated by Vitaly vit9696 5 months ago

Sure (y)

#11 Updated by Marius BALTEANU 4 months ago

  • Target version changed from 4.2.7 to 4.2.8

#12 Updated by Vitaly vit9696 3 months ago

Gentle ping.

#13 Updated by Vitaly vit9696 about 1 month ago

Hello, Go MAEDA, could you please test the attached patch and commit it if it works for you?
Your attention is also needed on this patch, which would be great to merge into 5.0.3 as well.
Thanks!

#14 Updated by Go MAEDA 5 days ago

  • Subject changed from Jump to project is misaligned in Safari 15.4 to Jump to project is misaligned in Safari 15.4 and later
  • Status changed from Confirmed to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for reporting and fixing the issue.

Also available in: Atom PDF