Project

General

Profile

Actions

Defect #37282

closed

Subtask isn't displayed correctly since 4.2.7

Added by Nono Nono almost 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

I can't reproduce a screenshot with 4.2.6 but the subtask looks different / not good since 4.2.7 :
subtask bar looks weird


Files

subtask_bug.png (24 KB) subtask_bug.png subtask bar looks weird Nono Nono, 2022-06-24 14:28
37282-confirmed.png (70.3 KB) 37282-confirmed.png Go MAEDA, 2022-06-30 03:48
37282-cjk.png (73.4 KB) 37282-cjk.png Go MAEDA, 2022-06-30 06:42
37282.patch (939 Bytes) 37282.patch Dmitry Makurin , 2022-07-18 21:35
fix_for_37282.patch (1.43 KB) fix_for_37282.patch Marius BĂLTEANU, 2022-09-27 22:45

Related issues

Related to Redmine - Defect #36453: Issue subject overflow in subtasks and relations tablesClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Go MAEDA almost 2 years ago

Could you elaborate on what the problem is?

Actions #2

Updated by Nono Nono almost 2 years ago

The columns should be distributed evenly, currently there is a line break in every column because the assignee is split across two lines (can't be seen on the screenshot so you have to trust me on this one :)

I suppose it is just a CSS issue: fixing column widths

Actions #3

Updated by Go MAEDA almost 2 years ago

Nono Nono wrote:

The columns should be distributed evenly, currently there is a line break in every column because the assignee is split across two lines (can't be seen on the screenshot so you have to trust me on this one :)

Confirmed the issue.

Actions #4

Updated by Go MAEDA almost 2 years ago

  • Status changed from New to Confirmed
Actions #6

Updated by Go MAEDA almost 2 years ago

The appearance is even worse if CJK ( Chinese / Japanese / Korean) characters are used in the assignee's name.

Actions #7

Updated by Marius BĂLTEANU almost 2 years ago

  • Target version set to 4.2.8
Actions #8

Updated by Go MAEDA almost 2 years ago

  • Related to Defect #36453: Issue subject overflow in subtasks and relations tables added
Actions #9

Updated by Go MAEDA almost 2 years ago

I think it would be good to revert r21642.

Actions #10

Updated by Dmitry Makurin almost 2 years ago

Attaching a patch. It adjusts subject width to 50% (as it was previous, wont take that much space) and fixes line breaks in the assigned_to column for CJK.

Actions #11

Updated by Marius BĂLTEANU over 1 year ago

@Go Maeda, the fix works for you? Or would you prefer to revert the changes?

Actions #12

Updated by Marius BĂLTEANU over 1 year ago

Can you test this one as well?

diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index 6f4796285..5207cec26 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -567,10 +567,13 @@ body.controller-issues h2.inline-flex {padding-right: 0}
   overflow: hidden;
 }
 #issue_tree .issue > td.subject, #relations .issue > td.subject {
-  width: 100%; /* let subject have one full width column */
+  width: 50%; /* let subject have one full width column */
   word-break: break-word; /* break word if subject is too long */
   padding-right: 25px; /* this is the spaces that .buttons uses next to subject */
 }
+#issue_tree .issue > td.assigned_to, #relations .issue > td.assigned_to {
+  white-space: nowrap;
+}
 #trackers_description {display:none;}
 #trackers_description dt {font-weight: bold; text-decoration: underline;}
 #trackers_description dd {margin: 0; padding: 0 0 1em 0;}
diff --git a/public/stylesheets/responsive.css b/public/stylesheets/responsive.css
index 3d3a41fff..d6282046d 100644
--- a/public/stylesheets/responsive.css
+++ b/public/stylesheets/responsive.css
@@ -774,6 +774,10 @@
     padding-right: 5px;
   }

+  #issue_tree .issue > td.subject, #relations .issue > td.subject {
+    width: 100%; /* let subject have one full width column */
+  }
+
   #issue_tree .issue > td:not(.subject), #relations .issue > td:not(.subject) {
     width: 20%; /* three columns for all cells that are not subject */
   }

Actions #13

Updated by Marius BĂLTEANU over 1 year ago

  • Subject changed from subtask isn't displayed correctly since 4.2.7 to Subtask isn't displayed correctly since 4.2.7
Actions #14

Updated by Go MAEDA over 1 year ago

I confirmed the both 37282.patch and fix_for_37282.patch fixes the issue described in #37282#6, and didn't find any side effects.

I think we don't have to revert r21642.

Actions #15

Updated by Marius BĂLTEANU over 1 year ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed

I've committed the second patch.

Actions #16

Updated by Marius BĂLTEANU over 1 year ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF