Feature #3800

Editing time entries should show the person involved

Added by Roderik van der Veer almost 11 years ago. Updated 4 months ago.

Status:ClosedStart date:2009-09-01
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Time tracking
Target version:4.1.1
Resolution:Fixed

Description

I'm currently running the trunk version of 30/8 and I'm working on an evaluation of a project based on the time-tracking features of Redmine. Now I'm cleaning up the activity settings of all the time entries and i noticed that the user involved is not show on the edit form. this is a pain because I've opened all wrongly assigned time entries in a tab, and now I'm not sure who did what and what the correct activity should be. The user is an essential part of the context needed when editing a time entry.

Screenshot 2020-03-08 at 23.07.39.png (65.7 KB) Marius BALTEANU, 2020-03-08 22:11

time_entry_user.png (76 KB) Marius BALTEANU, 2020-03-10 22:47

0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch Magnifier (2.12 KB) Marius BALTEANU, 2020-03-14 17:38

0002-show-user-name-in-time-entry-batch-edit.patch Magnifier (823 Bytes) Kevin Fischer, 2020-03-23 02:08


Related issues

Related to Redmine - Feature #3848: Permission to log time for another user Closed 2009-09-11

Associated revisions

Revision 19653
Added by Jean-Philippe Lang 4 months ago

Editing time entries should show the time entry user (#3800).

Patch by Marius BALTEANU.

Revision 19654
Added by Jean-Philippe Lang 4 months ago

Show user name in time entry bulk edit (#3800).

Patch by Kevin Fischer.

Revision 19662
Added by Jean-Philippe Lang 4 months ago

Fixed assertion broken by r19654 (#3800).

Revision 19664
Added by Jean-Philippe Lang 4 months ago

Merged r19653, r19654 and r19662 to 4.1-stable (#3800).

History

#1 Updated by Go MAEDA 5 months ago

  • Status changed from New to Closed
  • Resolution set to Duplicate

Implemented in Redmine 4.1.0 (#3848).

#2 Updated by Go MAEDA 5 months ago

  • Duplicates Feature #3848: Permission to log time for another user added

#3 Updated by Marius BALTEANU 5 months ago

  • Duplicates deleted (Feature #3848: Permission to log time for another user)

#4 Updated by Marius BALTEANU 5 months ago

  • Related to Feature #3848: Permission to log time for another user added

#5 Updated by Marius BALTEANU 5 months ago

  • File Screenshot 2020-03-08 at 23.07.39.png added
  • Status changed from Closed to Reopened
  • Assignee set to Marius BALTEANU
  • Target version set to Candidate for next major release
  • Resolution deleted (Duplicate)

It's implemented only for users with permission to log time for other users. I think we can add an read only field also for users without permissions.

#6 Updated by Go MAEDA 5 months ago

Marius BALTEANU wrote:

I think we can add an read only field also for users without permissions.

+1

#7 Updated by Marius BALTEANU 5 months ago

We can show the user as link/string instead of a read only field, it's ok?

#8 Updated by Marius BALTEANU 5 months ago

  • Subject changed from Edititng time entries should show the person involved to Editing time entries should show the person involved

#9 Updated by Marius BALTEANU 5 months ago

Here is the patch, I think it's safe to deliver this in 4.1.1

Tests result here

#10 Updated by Kevin Fischer 5 months ago

Patch looks good to me!

By the way: When I looked at the current behaviour I was thinking:

Wouldn't it be convenient if the User of each time entry was also displayed in the link text of each time entry on the top? It would address the same problem as in the original post...

I added a potential patch for that...

#11 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from Reopened to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Both patches committed, thanks.
Just a slight change to Kevin's patch to prevent calling #name on nil.

#12 Updated by Marius BALTEANU 4 months ago

Test fails:

 Failure:
 TimelogControllerTest#test_get_bulk_edit [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:712]:
 <03/23/2007 - eCookbook: 4.25 hours> expected but was
 <03/23/2007 - eCookbook: 4.25 hours (John Smith)>..
 Expected 0 to be >= 1.
 bin/rails test test/functional/timelog_controller_test.rb:706

#13 Updated by Jean-Philippe Lang 4 months ago

  • Status changed from Resolved to Closed

Merged.

Also available in: Atom PDF