Project

General

Profile

Actions

Feature #3800

closed

Editing time entries should show the person involved

Added by Roderik van der Veer over 14 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Time tracking
Target version:
Start date:
2009-09-01
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

I'm currently running the trunk version of 30/8 and I'm working on an evaluation of a project based on the time-tracking features of Redmine. Now I'm cleaning up the activity settings of all the time entries and i noticed that the user involved is not show on the edit form. this is a pain because I've opened all wrongly assigned time entries in a tab, and now I'm not sure who did what and what the correct activity should be. The user is an essential part of the context needed when editing a time entry.


Files


Related issues

Related to Redmine - Feature #3848: Permission to log time for another userClosedJean-Philippe Lang2009-09-11

Actions
Actions #1

Updated by Go MAEDA about 4 years ago

  • Status changed from New to Closed
  • Resolution set to Duplicate

Implemented in Redmine 4.1.0 (#3848).

Actions #2

Updated by Go MAEDA about 4 years ago

  • Is duplicate of Feature #3848: Permission to log time for another user added
Actions #3

Updated by Marius BĂLTEANU about 4 years ago

  • Is duplicate of deleted (Feature #3848: Permission to log time for another user)
Actions #4

Updated by Marius BĂLTEANU about 4 years ago

  • Related to Feature #3848: Permission to log time for another user added
Actions #5

Updated by Marius BĂLTEANU about 4 years ago

It's implemented only for users with permission to log time for other users. I think we can add an read only field also for users without permissions.

Actions #6

Updated by Go MAEDA about 4 years ago

Marius BALTEANU wrote:

I think we can add an read only field also for users without permissions.

+1

Actions #7

Updated by Marius BĂLTEANU about 4 years ago

We can show the user as link/string instead of a read only field, it's ok?

Actions #8

Updated by Marius BĂLTEANU about 4 years ago

  • Subject changed from Edititng time entries should show the person involved to Editing time entries should show the person involved
Actions #9

Updated by Marius BĂLTEANU about 4 years ago

Here is the patch, I think it's safe to deliver this in 4.1.1

Tests result here

Actions #10

Updated by Kevin Fischer about 4 years ago

Patch looks good to me!

By the way: When I looked at the current behaviour I was thinking:

Wouldn't it be convenient if the User of each time entry was also displayed in the link text of each time entry on the top? It would address the same problem as in the original post...

I added a potential patch for that...

Actions #11

Updated by Jean-Philippe Lang about 4 years ago

  • Status changed from Reopened to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Both patches committed, thanks.
Just a slight change to Kevin's patch to prevent calling #name on nil.

Actions #12

Updated by Marius BĂLTEANU about 4 years ago

Test fails:

 Failure:
 TimelogControllerTest#test_get_bulk_edit [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:712]:
 <03/23/2007 - eCookbook: 4.25 hours> expected but was
 <03/23/2007 - eCookbook: 4.25 hours (John Smith)>..
 Expected 0 to be >= 1.
 bin/rails test test/functional/timelog_controller_test.rb:706
Actions #13

Updated by Jean-Philippe Lang about 4 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF