Feature #3800
Editing time entries should show the person involved
| Status: | Closed | Start date: | 2009-09-01 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Jean-Philippe Lang | % Done: | 0% | |
| Category: | Time tracking | |||
| Target version: | 4.1.1 | |||
| Resolution: | Fixed |
Description
I'm currently running the trunk version of 30/8 and I'm working on an evaluation of a project based on the time-tracking features of Redmine. Now I'm cleaning up the activity settings of all the time entries and i noticed that the user involved is not show on the edit form. this is a pain because I've opened all wrongly assigned time entries in a tab, and now I'm not sure who did what and what the correct activity should be. The user is an essential part of the context needed when editing a time entry.
Screenshot 2020-03-08 at 23.07.39.png (65.7 KB)
time_entry_user.png (76 KB)
0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch 
(2.12 KB)
0002-show-user-name-in-time-entry-batch-edit.patch
(823 Bytes)
Related issues
Associated revisions
Editing time entries should show the time entry user (#3800).
Patch by Marius BALTEANU.
Show user name in time entry bulk edit (#3800).
Patch by Kevin Fischer.
History
#1
Updated by Go MAEDA over 2 years ago
- Status changed from New to Closed
- Resolution set to Duplicate
Implemented in Redmine 4.1.0 (#3848).
#2
Updated by Go MAEDA over 2 years ago
- Duplicates Feature #3848: Permission to log time for another user added
#3
Updated by Marius BALTEANU over 2 years ago
- Duplicates deleted (Feature #3848: Permission to log time for another user)
#4
Updated by Marius BALTEANU over 2 years ago
- Related to Feature #3848: Permission to log time for another user added
#5
Updated by Marius BALTEANU over 2 years ago
- File Screenshot 2020-03-08 at 23.07.39.png added
- Status changed from Closed to Reopened
- Assignee set to Marius BALTEANU
- Target version set to Candidate for next major release
- Resolution deleted (
Duplicate)
It's implemented only for users with permission to log time for other users. I think we can add an read only field also for users without permissions.
#6
Updated by Go MAEDA over 2 years ago
Marius BALTEANU wrote:
I think we can add an read only field also for users without permissions.
+1
#7
Updated by Marius BALTEANU over 2 years ago
- File time_entry_user.png added
We can show the user as link/string instead of a read only field, it's ok?
#8
Updated by Marius BALTEANU over 2 years ago
- Subject changed from Edititng time entries should show the person involved to Editing time entries should show the person involved
#9
Updated by Marius BALTEANU over 2 years ago
- File 0001-Show-time-entry-user-info-in-edit-page-also-for-user.patch added
- Assignee deleted (
Marius BALTEANU) - Target version changed from Candidate for next major release to 4.1.1
#10
Updated by Kevin Fischer over 2 years ago
Patch looks good to me!
By the way: When I looked at the current behaviour I was thinking:
Wouldn't it be convenient if the User of each time entry was also displayed in the link text of each time entry on the top? It would address the same problem as in the original post...
I added a potential patch for that...
#11
Updated by Jean-Philippe Lang over 2 years ago
- Status changed from Reopened to Resolved
- Assignee set to Jean-Philippe Lang
- Resolution set to Fixed
Both patches committed, thanks.
Just a slight change to Kevin's patch to prevent calling #name on nil.
#12
Updated by Marius BALTEANU over 2 years ago
Test fails:
Failure: TimelogControllerTest#test_get_bulk_edit [/builds/redmine-org/redmine/test/functional/timelog_controller_test.rb:712]: <03/23/2007 - eCookbook: 4.25 hours> expected but was <03/23/2007 - eCookbook: 4.25 hours (John Smith)>.. Expected 0 to be >= 1. bin/rails test test/functional/timelog_controller_test.rb:706