Defect #38199
closed
Fix deprecation warning for db:structure:dump in db:migrate when using sql schema format
Added by Dmitry Makurin over 1 year ago.
Updated about 1 year ago.
Description
Running db:migrate using sql schema format shows the deprecation warning:
DEPRECATION WARNING: Using `bin/rails db:structure:dump` is deprecated and will be removed in Rails 7.0. Configure the format using `config.active_record.schema_format = :sql` to use `structure.sql` and run `bin/rails db:schema:dump` instead. (called from block (3 levels) in <top (required)> at lib/tasks/redmine.rake:160)
Redmine invokes db:schema/structures:dump to dump plugins migrations.
Files
- Related to Patch #31485: Add support for :sql ActiveRecord::Base.schema_format in redmine:plugins:migrate added
- Category set to Rails support
- Status changed from New to Confirmed
Steps to reproduce:
$ echo 'config.active_record.schema_format = :sql' >> config/additional_environment.rb
$ bin/rake redmine:plugins:migrate
Setting the target version to 5.0.5.
- Subject changed from Using `bin/rails db:structure:dump` is deprecated and will be removed in Rails 7.0. to Fix "DEPRECATION WARNING: Using `bin/rails db:structure:dump`" when migrating plugins using sql schema format
I guess we need to provide backward compatibility for Rails 6.1.
db:structure:dump will be removed only in Rails 7.0 but the current trunk works on 6.1+.
Attaching a new patch 38199_v2.patch.
- Target version changed from 5.0.5 to 5.1.0
- Target version changed from 5.1.0 to 5.0.5
Dmitry Makurin wrote:
I guess we need to provide backward compatibility for Rails 6.1.
db:structure:dump will be removed only in Rails 7.0 but the current trunk works on 6.1+.
Attaching a new patch 38199_v2.patch.
I think the first patch work with Rails 6.1. It seems that db:schema:dump generates db/structure.sql also with Rails 6.1.
$ rm db/structure.sql
ls db/structure.sql
ls: db/structure.sql: No such file or directory
$ bin/rake redmine:plugins:migrate
$ ls db/structure.sql
db/structure.sql
- Subject changed from Fix "DEPRECATION WARNING: Using `bin/rails db:structure:dump`" when migrating plugins using sql schema format to Fix deprecation warning for db:structure:dump in db:migrate when using sql schema format
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the fix. Thank you.
- Status changed from Resolved to Closed
Also available in: Atom
PDF
Updated by 
Updated by