Patch #38975: Use ApplicationRecord instead of ActiveRecord::Base - Redmine

Actions

Copy link

Patch #38975

closed

Use ApplicationRecord instead of ActiveRecord::Base

Added by Minoru Maeda about 2 years ago. Updated almost 2 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Code cleanup/refactoring

Target version:

6.0.0

Start date:

Due date:

% Done:

Estimated time:

Description

This patch changes the base class of the Active Record model in app/models to ApplicationRecord.

This is in accordance with the change of model inheritance from ActiveRecord::Base to ApplicationRecord in Rails 5.
Reference link: https://www.bigbinary.com/blog/application-record-in-rails-5

However, the include destination of lib/plugins/acts_as_xxx will also change from ActiveRecord::Base to ApplicationRecord when this patch is applied,
This will affect the Active Record model of Redmine plugins that use the acts_as_xxx method, and the base class will need to be changed to ApplicationRecord.

Thank you.

Files

Download all files

use_application_record_models.patch (32.5 KB) use_application_record_models.patch		Minoru Maeda, 2023-08-23 09:12
38975-v2.patch (31.3 KB) 38975-v2.patch		Go MAEDA, 2023-12-30 09:33

Actions

Copy link

Updated by Mizuki ISHIKAWA about 2 years ago

+1
Since the use of ApplicationRecord has become standard practice in Rails 5 and beyond, I think it would be beneficial for Redmine to stay up-to-date with this approach.

Actions

Copy link