Actions
Patch #42521
open
Reimplement modal dialog with Stimulus
Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:
0%
Estimated time:
Description
This patch replaces the jQuery UI dialog with a reimplemented modal dialog with Stimulus. It is assumed that Stimulus has been installed with the #42515 patch.
The new modal dialog uses SVG icons.
I've also created JavaScript tests that run in the browser. I think now would be a good time to add JavaScript testing to the Redmine environment.
- To simplify testing within the importmap environment, I created the importmap_mocha-rails gem , a simple gem that integrates JavaScript testing tools.
- In development or test mode, test results are displayed at http://localhost:3000/rails/info/mocha.
- importmap_mocha-reils can be used in combination with rails_live_reload gem.
Files
Related issues
Updated by Marius BĂLTEANU about 2 months ago
Thanks for your work and for the patches.
Let's discuss the integration of Stimulus in #42510 and then we can get back to this.
Updated by Marius BĂLTEANU about 2 months ago
- Related to Feature #42510: Add Stimulus as a Javascript framework added
Updated by Takashi Kato 12 days ago
- File 0001v2-Add-daialog-controller-and-dialog-dispatcher-control.patch 0001v2-Add-daialog-controller-and-dialog-dispatcher-control.patch added
I've updated the first patch.
It was working in Firefox, but I noticed a problem with the dialog not closing in Chrome.
Updated by
Actions