Project

General

Profile

Actions

Patch #42521

open

Reimplement modal dialog with Stimulus

Added by Takashi Kato about 2 months ago. Updated 4 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Start date:
Due date:
% Done:

0%

Estimated time:

Description

This patch replaces the jQuery UI dialog with a reimplemented modal dialog with Stimulus. It is assumed that Stimulus has been installed with the #42515 patch.
The new modal dialog uses SVG icons.

I've also created JavaScript tests that run in the browser. I think now would be a good time to add JavaScript testing to the Redmine environment.


Files


Related issues

Related to Redmine - Feature #42510: Add Stimulus as a Javascript frameworkResolvedMarius BĂLTEANU

Actions
Actions #1

Updated by Marius BĂLTEANU about 1 month ago

Thanks for your work and for the patches.

Let's discuss the integration of Stimulus in #42510 and then we can get back to this.

Actions #2

Updated by Marius BĂLTEANU about 1 month ago

  • Related to Feature #42510: Add Stimulus as a Javascript framework added
Actions #3

Updated by Takashi Kato 10 days ago

I've updated the first patch.
It was working in Firefox, but I noticed a problem with the dialog not closing in Chrome.

Actions #4

Updated by Go MAEDA 4 days ago

  • Target version set to Candidate for next major release
Actions

Also available in: Atom PDF