Redmine

Thanks for your work and for the patches.

Let's discuss the integration of Stimulus in #42510 and then we can get back to this.

Thank you for your work on this patch. I noticed that with the new dialog implementation, pressing the Escape key no longer closes the dialog.

Do you think we should support the Escape key to close dialogs?

Go MAEDA wrote in #note-6:

Thank you for your work on this patch. I noticed that with the new dialog implementation, pressing the Escape key no longer closes the dialog.

Do you think we should support the Escape key to close dialogs?

Thank you for your feedback!
I think it's important to be able to close a dialog with the Escape key.
This is achieved by fixing the data-action attribute as follows.

diff --git a/app/views/common/_dialog.html.erb b/app/views/common/_dialog.html.erb
index 6317d48d3e..bfdf893006 100644
--- a/app/views/common/_dialog.html.erb
+++ b/app/views/common/_dialog.html.erb
@@ -1,5 +1,5 @@
 <%= tag.div style: 'display:none', class: 'modal', id: id, data: (data || { controller: 'dialog' })  do %>
-  <div class="handle" data-action="pointerdown->dialog#start pointerup->dialog#end pointercancel->dialog#end pointermove->dialog#move touchstart->dialog#noop dragstart->dialog#noop" data-dialog-target="handler">
+  <div class="handle" data-action="pointerdown->dialog#start pointerup->dialog#end pointercancel->dialog#end pointermove->dialog#move touchstart->dialog#noop dragstart->dialog#noop keydown.esc@window->dialog#cancel" data-dialog-target="handler">
     <span class="title"><%= title %></span>
     <%= tag.button type: "button", title: l(:button_close_dialog), data: {action: "dialog#cancel", dialog_target: 'cancel'} do %>
       <%= sprite_icon 'close-dialog'%>