Feature #43085
closed
Scroll to notes section instead of top of edit form when quoting issue content
Added by kyohei yamada 8 months ago.
Updated 16 days ago.
Description
When a comment or description is quoted, it scrolls to the top of the edit screen.
In some cases, such as when there are many items displayed, the comment may not appear.
We believe that quoting is when you want to comment, so it is natural to scroll to the comment position.
Files
Thank you for posting the patch.
However, the patch causes some existing system tests to fail in my environment. Could you check in your environment?
I fixed the code so that the previously failing test now passes.
$ GOOGLE_CHROME_OPTS_ARGS="--headless" bin/rails test test/system/issues_reply_test.rb
/Users/kyamada/.rbenv/versions/3.4.7/lib/ruby/gems/3.4.0/gems/net-ldap-0.17.1/lib/net/ldap.rb:2: warning: ostruct was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Run options: --seed 40134
# Running:
Capybara starting Puma...
* Version 7.1.0, codename: Neon Witch
* Min threads: 0, max threads: 4
* Listening on http://127.0.0.1:52050
......
Finished in 4.894999s, 1.2257 runs/s, 5.3115 assertions/s.
6 runs, 26 assertions, 0 failures, 0 errors, 0 skips
- Target version set to Candidate for next major release
- Target version changed from Candidate for next major release to 7.0.0
Setting the target version to 7.0.0.
- Subject changed from Scroll position to comment position when quoting comments or descriptions to Scroll to notes section instead of top of edit form when quoting issue content
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch in r24521. Thank you for your contribution.
Also available in: Atom
PDF
Updated by 
Updated by