Project

General

Profile

Actions

Defect #43143

open

Edit heading is hidden behind sticky header after clicking the "Edit" link on issue page

Added by Mizuki ISHIKAWA 5 days ago. Updated 2 days ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Affected version:

Description

On the issue page, when clicking the Edit link, the page scrolls to the edit section. However, the sticky header covers the Edit heading, making it unclear that the user has reached the section.
Related: Feature #42684: Add a sticky header to keep the issue subject visible on scroll
The scroll should be adjusted so the heading is fully visible.

Current Expected
Steps to Reproduce:
  • Open an issue
  • Click the Edit link
  • The Edit heading is hidden behind the sticky header

Files

Actions #1

Updated by Mizuki ISHIKAWA 5 days ago

0001-Adjust-scrolling-to-keep-Edit-heading-visible.patch
  • Added scroll-margin-top for #update.
  • Replaced jQuery animate() with native scrollIntoView(), which takes scroll-margin-top into account.
  • Use the native focus() function with preventScroll: true to prevent automatic scrolling when setting focus
0002-Add-system-test-for-Edit-heading-visibility.patch
  • Added system test to confirm the heading is visible.
    • The test uses JavaScript to check that the Edit heading is not hidden. Since this check may be fragile, please decide whether to include it in the commit.
Actions #2

Updated by Mizuki ISHIKAWA 5 days ago

Regarding the patch for #note-1, scrollIntoView does not allow specifying the scroll speed and depends on the browser, so scrolling becomes slightly slower than before (100ms).

Actions #3

Updated by Mizuki ISHIKAWA 2 days ago

Mizuki ISHIKAWA wrote in #note-2:

Regarding the patch for #note-1, scrollIntoView does not allow specifying the scroll speed and depends on the browser, so scrolling becomes slightly slower than before (100ms).

I've attached a patch that changes the scrollIntoView option from behavior: 'smooth' to behavior: 'instant' so that the behavior is closer to the previous one.
https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoView#behavior

Actions #4

Updated by Go MAEDA 2 days ago

  • Target version set to 6.0.7

Setting the target version to 6.0.7.

Actions

Also available in: Atom PDF