Patch #43214
closed
Optimize Project.allowed_to_condition by replacing `projects.status <> ...` with `projects.status IN (...)`
Added by Go MAEDA 6 months ago.
Updated 6 months ago.
Description
The attached patch replaces the condition projects.status <> ... with the equivalent projects.status IN (...) in the Project.allowed_to_condition method.
This change makes the SQL clearer and may improve performance, since IN (...) is generally more optimizer-friendly than a combination of <> conditions. A performance benefit of this approach was also observed during the investigation of #40728 (see #40728#note-15 and #40728#note-16).
Files
- Subject changed from Optimize Project.allowed_to_condition by `replacing projects.status <> ...` with `projects.status IN (...)` to Optimize Project.allowed_to_condition by replacing `projects.status <> ...` with `projects.status IN (...)`
Looks good to me, thanks!
- Description updated (diff)
- Target version set to 6.1.0
- Related to Feature #36691: Background job and dedicated status for project deletion added
- Status changed from New to Closed
- Assignee set to Go MAEDA
Thank you for reviwing the change. I have committed the change in r23979.
- Related to Defect #43651: Searching issues with searchable custom fields causes a performance regression on MySQL added
Also available in: Atom
PDF