Project

General

Profile

Actions

Feature #43259

open

Replace jsToolBar with a server-rendered wiki toolbar handled by a Stimulus controller

Feature #43259: Replace jsToolBar with a server-rendered wiki toolbar handled by a Stimulus controller

Added by Takashi Kato about 1 year ago. Updated 17 days ago.

Status:
New
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Resolution:

Description

This patch is based on a branch from #43165, with minor modifications.

  • Converting the entire library to ES modules eliminates the risk of variable name collisions.
  • Refactored jstoolbar from the old prototype-based syntax to a more readable class syntax.
  • Switched DOM element creation from JavaScript to ERB, which makes preparing and cloning DOM elements easier by using the <template> element.
  • Moved all jstoolbar locales to config/locales to simplify i18n. * Added the missing tasklist locale for both ja and en.
  • Integrated the list-autofill controller into jstoolbar as both controllers are used in the same places.

Applying this patch along with #42521 enables the implementation of #40310.

This patch can be applied to r24014


Files

0001-Convert-jstoolbar-to-ES-Module.patch (227 KB) 0001-Convert-jstoolbar-to-ES-Module.patch Takashi Kato, 2025-09-28 06:01
0001-wip.patch (44.8 KB) 0001-wip.patch Marius BĂLTEANU, 2026-02-21 19:43
0001-jstoolbar-to-stimulus.patch (46.9 KB) 0001-jstoolbar-to-stimulus.patch Takashi Kato, 2026-03-01 03:14
0001-Define-the-wiki-toolbar-markup-in-JavaScript-for-eac.patch (26.1 KB) 0001-Define-the-wiki-toolbar-markup-in-JavaScript-for-eac.patch Marius BĂLTEANU, 2026-10-28 22:52
0001-wiki-toolbar-keep-textarea-focus.patch (1.01 KB) 0001-wiki-toolbar-keep-textarea-focus.patch Florian Walchshofer, 2026-10-30 21:58
0002-wiki-toolbar-keep-menus-in-viewport.patch (1003 Bytes) 0002-wiki-toolbar-keep-menus-in-viewport.patch Florian Walchshofer, 2026-10-30 21:58
0003-wiki-toolbar-return-focus-after-escape.patch (1.98 KB) 0003-wiki-toolbar-return-focus-after-escape.patch Florian Walchshofer, 2026-10-30 21:58
0004-wiki-toolbar-allow-plugins-to-add-buttons.patch (5.48 KB) 0004-wiki-toolbar-allow-plugins-to-add-buttons.patch Florian Walchshofer, 2026-10-30 21:58
0001-Keep-wiki-toolbar-menus-from-being-clipped-by-the-fo.patch (4.21 KB) 0001-Keep-wiki-toolbar-menus-from-being-clipped-by-the-fo.patch Go MAEDA, 2026-11-03 09:10
0002-Find-wiki-toolbar-buttons-defined-in-modules-include.patch (2.02 KB) 0002-Find-wiki-toolbar-buttons-defined-in-modules-include.patch Go MAEDA, 2026-11-03 09:10
0003-Fix-error-in-deprecated-wikitoolbar_for-when-the-for.patch (2.12 KB) 0003-Fix-error-in-deprecated-wikitoolbar_for-when-the-for.patch Go MAEDA, 2026-11-03 09:10
0004-Let-text-formatters-without-toolbar-buttons-render-t.patch (2.59 KB) 0004-Let-text-formatters-without-toolbar-buttons-render-t.patch Go MAEDA, 2026-11-03 09:10
0005-Fix-JavaScript-error-on-wiki-toolbar-shortcuts-when-.patch (1.45 KB) 0005-Fix-JavaScript-error-on-wiki-toolbar-shortcuts-when-.patch Go MAEDA, 2026-11-03 09:10

Related issues 1 (1 open — 0 closed)

Related to Redmine - Patch #37559: Use meta element instead of javascript objectNewMarius BĂLTEANUActions
Actions

Also available in: PDF Atom