Redmine

Committed with a test, thanks!

The translation feature caused an issue where alert box titles were always translated, even when a custom title was specified by the user, like this:

> [!Tip] Useful hint
> You can override the default alert box title

With the above example, the displayed title should be "Useful hint", but currently it incorrectly displays the default title "Tip".

The attached patch fixes the issue.

Thanks Go MAEDA i can confirm this patch.

> [!Tip] Useful hint
> You can override the default alert box title, ok

> [!Tip] 
> Standard alert box tip in german

Marius BĂLTEANU wrote in #note-9:

Go MAEDA, thanks for catching this issue!

I think we can fix it also in one line:

1. node.content = ::I18n.t("label_alert_#{node.content.downcase}", default: node.content): this could lead to an unexpected translation if we add another label_alert_<something> in the future that is not part of the commonmark alerts.

2. node.content = ::I18n.t("label_alert_#{alert_type}", default: node.content) if ALERT_TYPE_TO_ICON_NAME.key?(node.content.downcase)

Thank you for your refined code suggestions. I think the second option is the best. Checking if node.content.downcase matches a key in ALERT_TYPE_TO_ICON_NAME is not only safe, but also makes it clear that the translation should be done only if node.content is a string like "Note" or "Warning".

I am attaching a patch updated based on the last option.