Patch #43396
closed
Update propshaft to 1.3
0%
Description
This is a patch to update propshaft to ver1.3.
Since propshaft 1.2 and later support SRI for assets, Redmine may also need to consider implementing this support (though this patch does not do anything).
Files
Related issues
Updated by Go MAEDA about 2 months ago
- Target version set to Candidate for next major release
Updated by Marius BĂLTEANU about 2 months ago
- Status changed from New to Closed
- Assignee set to Marius BĂLTEANU
- Target version changed from Candidate for next major release to 7.0.0
Updated by Go MAEDA about 1 month ago
- Related to Defect #43436: Assets are not compiled on startup in production mode with Propshaft 1.3.0 added
Updated by Go MAEDA about 1 month ago
- Status changed from Closed to Reopened
As reported in #43436, auto-compile of assets that can be turned on with config.assets.redmine_detect_update does not work after this change.
Updated by Takashi Kato about 1 month ago
Go MAEDA wrote in #note-4:
As reported in #43436, auto-compile of assets that can be turned on with
config.assets.redmine_detect_updatedoes not work after this change.
This was caused by Propshaft::Assembly instansiation happening during initialize instead of after_initialize, due to the following change:
https://github.com/rails/propshaft/pull/249
I extracted the asset compilation process and fixed the timing to run during after_initialize.
Updated by Takenori TAKAKI about 1 month ago
I propose a follow-up patch to improve the patch attached in #note-5.
This patch moves the redmine_detect_update check from Propshaft::Assembly#needs_precompile? to the after_initialize block in 30-redmine.rb.
This keeps needs_precompile? focused on checking whether the manifest is missing or outdated, while the Redmine-specific condition is handled during application initialization.
Asset precompilation on startup works correctly in my environment after applying this patch.
Updated by Takashi Kato about 1 month ago
Thank you! I think the patch update has clarified the separation between environmental issues and user intentions, making it easier to understand.