Project

General

Profile

Actions
Copy link

Defect #43801

closed

Copy button appears only on the last pre when multiple pre blocks exist

Added by Mizuki ISHIKAWA 24 days ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Marius BĂLTEANU
Category:
UI
Target version:
-
Resolution:
Fixed
Affected version:

Description

When a page contains multiple pre blocks, the copy button is displayed only on the last pre block.
Expected behavior: A copy button should be shown for each pre block.

This issue occurs after applying r24360 from issue #43643.

Related issues

Related to Redmine - Patch #42737: Replacing html-pipeline with Loofah for HTML FilteringClosedMarius BĂLTEANUActions
Actions
Copy link
 #1

Updated by Mizuki ISHIKAWA 24 days ago

I think the following changes will resolve the issue.

diff --git a/lib/redmine/wiki_formatting/copypre_scrubber.rb b/lib/redmine/wiki_formatting/copypre_scrubber.rb
index 2afd02823..0157f9921 100644
--- a/lib/redmine/wiki_formatting/copypre_scrubber.rb
+++ b/lib/redmine/wiki_formatting/copypre_scrubber.rb
@@ -27,6 +27,7 @@ module Redmine
         button_copy = ApplicationController.helpers.l(:button_copy)
         html = '<a class="copy-pre-content-link icon-only" title="' + button_copy + '" data-action="clipboard#copyPre">' + icon + '</a>'
         @button ||= Nokogiri::HTML5.fragment(html).children.first
+        @button.deep_dup
       end
     end
   end

Actions
Copy link
 #2

Updated by Go MAEDA 21 days ago

  • Assignee set to Marius BĂLTEANU

Marius, could you handle this?

Actions
Copy link
 #3

Updated by Marius BĂLTEANU 21 days ago

Yes, I will do it these days.

Actions
Copy link
 #4

Updated by Marius BĂLTEANU 18 days ago

  • Related to Patch #42737: Replacing html-pipeline with Loofah for HTML Filtering added
Actions
Copy link
 #5

Updated by Marius BĂLTEANU 18 days ago

  • Status changed from New to Resolved
  • Resolution set to Fixed

Fixed by removing the cached instance variable. In this way, if the user changes his language, the copy button will properly show the updated translation.

Actions
Copy link
 #6

Updated by Marius BĂLTEANU 18 days ago

  • Status changed from Resolved to Closed

Added a test.

Actions
Copy link

Also available in: Atom PDF