Project

General

Profile

Actions

Defect #44244

open

Spent time tab on issue page does not render commit references as links

Added by Takenori TAKAKI 1 day ago. Updated about 10 hours ago.

Status:
Needs feedback
Priority:
Normal
Category:
UI
Target version:
Resolution:
Affected version:

Description

On the issue detail page, the Associated revisions tab displays revision identifiers as clickable links to the corresponding revision page.

However, in the Spent time tab, time entries that were automatically logged via commit message show the associated revision as plain text (e.g. `Applied in changeset commit:a85130f`) without any link.

This is inconsistent with the Associated revisions tab behavior.

Root cause

`app/views/issues/tabs/_time_entries.html.erb` outputs `time_entry.comments` as plain text. It needs to go through `textilizable` so that Redmine link syntax (e.g. `commit:xxx`) is resolved to an HTML link.

Fix

- <%= time_entry.comments %>
+ <%= textilizable(time_entry, :comments) %>

Before:

After:

A patch is attached.


Files


Related issues

Related to Redmine - Feature #202: Textilization of Documents, News and Timelog-entry commentsNewActions
Actions #1

Updated by Marius BĂLTEANU about 11 hours ago

  • Category set to UI
  • Status changed from New to Resolved
  • Assignee set to Marius BĂLTEANU
  • Target version set to 6.1.4
  • Resolution set to Fixed

Committed, thanks!

Actions #2

Updated by Marius BĂLTEANU about 10 hours ago

  • Related to Feature #202: Textilization of Documents, News and Timelog-entry comments added
Actions #3

Updated by Marius BĂLTEANU about 10 hours ago

I've reverted the commit because the time entries comments are not textilizable, there is a very old request to support this, please see #202.

Actions #4

Updated by Marius BĂLTEANU about 10 hours ago

  • Status changed from Resolved to Needs feedback
  • Resolution deleted (Fixed)
Actions

Also available in: Atom PDF