Project

General

Profile

Actions

Feature #202

open

Textilization of Documents, News and Timelog-entry comments

Added by Warren Harris about 16 years ago. Updated 5 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

I've noticed another missing textilization:

Under projects/list_documents page, documents are listed with
a preview of their descriptions. However, the descriptions are
not textilized. When the description is shown under the documents/show
page, it is correctly textilized.


Files

news-summ.patch (1.92 KB) news-summ.patch Warren Harris, 2008-02-03 10:56
doc-descr.patch (725 Bytes) doc-descr.patch Warren Harris, 2008-02-03 10:56
textilize-document-description_r3084.patch (663 Bytes) textilize-document-description_r3084.patch Patch against trunk at r3084. Mischa The Evil, 2009-11-22 22:34
textilize-news-summary_r3084.patch (1.2 KB) textilize-news-summary_r3084.patch Patch against trunk at r3084. Mischa The Evil, 2009-11-22 22:34
textilize-timelog-entry-comment_r3084.patch (581 Bytes) textilize-timelog-entry-comment_r3084.patch Patch against trunk at r3084. Mischa The Evil, 2009-11-22 22:34
long_and_textilized_time_entry_comments.patch (4.23 KB) long_and_textilized_time_entry_comments.patch Gustavo Gama, 2010-03-19 15:49
textilization_for_spent_time_comments.patch (1.9 KB) textilization_for_spent_time_comments.patch Marius BĂLTEANU, 2016-12-29 22:57
textilization_for_spent_time_comments_with_test.patch (3.71 KB) textilization_for_spent_time_comments_with_test.patch Takenori TAKAKI, 2022-06-01 09:05
clipboard-202310091009-lju9y.png (34.7 KB) clipboard-202310091009-lju9y.png Go MAEDA, 2023-10-09 03:09
textilization_for_spent_time_comments_with_test-fix-21.patch (4 KB) textilization_for_spent_time_comments_with_test-fix-21.patch Takenori TAKAKI, 2023-10-12 07:07

Related issues

Related to Redmine - Defect #3740: Code syntax highlighting not working in Document pageClosed2009-08-14

Actions
Related to Redmine - Defect #5104: Description of document not wikified on documents indexClosed2010-03-17

Actions
Related to Redmine - Patch #258: Textilize document snippet on overview and activity pageNew

Actions
Related to Redmine - Feature #8668: make project overview text input fully wiki input text enabledClosed2011-06-222013-03-24

Actions
Related to Redmine - Feature #1179: Optionally allow Text and Long Text custom fields support wiki formattingClosedJean-Philippe Lang2008-05-05

Actions
Has duplicate Redmine - Defect #3406: Documents view does not parse textile syntax, while detailed view in documents does.Closed2009-05-22

Actions
Has duplicate Redmine - Patch #221: Textilized timelog commentsClosed2007-06-26

Actions
Has duplicate Redmine - Patch #4579: Missing Textilization on Document IndexClosed2010-01-14

Actions
Has duplicate Redmine - Patch #3815: Format links in TimelogClosed2009-09-03

Actions
Has duplicate Redmine - Feature #3810: Link to SCM Revision from Time Tracking SummaryClosed2009-09-02

Actions
Has duplicate Redmine - Feature #4627: Wiki style Formatting in a few placesClosed2010-01-22

Actions
Has duplicate Redmine - Defect #6038: wiki formatting in spent time commentsClosed2010-08-05

Actions
Actions #1

Updated by Warren Harris about 16 years ago

Here's another one... seems like there's no reason the news
summary shouldn't also be textilized. (patch included)

Actions #2

Updated by Mischa The Evil over 14 years ago

  • Category set to Text formatting

Just a bump on the issue. Plus is seems slightly related to issue #3740.

Actions #3

Updated by Mischa The Evil over 14 years ago

  • Subject changed from another missing textilization to Textilization of Documents and News

Changed subject only.

Actions #4

Updated by Mischa The Evil over 14 years ago

  • Tracker changed from Defect to Feature
Actions #5

Updated by Mischa The Evil over 14 years ago

Warren Harris wrote:

[...] When the description is shown under the documents/show
page, it is correctly textilized [...]

Except that syntax-highlighting isn't working in that specific case: see issue #3740.

Actions #6

Updated by Mischa The Evil over 14 years ago

I'll make a summary of several different changes regarding proposals to render content as being "textilized":

1. I'll start with the initial request: At the documents page (at http://host.domain.tld/projects/projectfoo/documents) documents are listed with a preview of their descriptions. However, the descriptions are not textilized.
When the description is shown under the documents/show page (at http://host.domain.tld/documents/1), it is correctly textilized.

(patch; textilize-document-description_r3084.patch)

2. Lateron in the journal of this issue the textilisation of the news summary is also proposed and patched.

(patch; textilize-news-summary_r3084.patch)

3. I've now also merged issue #221 into this issue. It's basically a simple request to render the timelog-entry comments also textilized.

(patch; textilize-timelog-entry-comment_r3084.patch)

I've rebased all three patches against the latest trunk and attached them to this issue. I'll close/update issue #221 as being a (partial) duplicate of this issue (patch #221 does some more then what the issue's description says, which is only textilisation of the timelog-comment).

Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?

Actions #7

Updated by Mischa The Evil over 14 years ago

Mischa The Evil wrote:

[...] several different changes regarding proposals to render content as being "textilized":

1. [...] (patch; textilize-document-description_r3084.patch) [...]

2. [...] (patch; textilize-news-summary_r3084.patch [...]

3. [...] (patch; textilize-timelog-entry-comment_r3084.patch [...]

[...]

Can a Redmine Lead decide which of the patches will be implemented (in future) and decline the ones that aren't get integrated?

My personal proposal would be to only merge the patch for number 3. That one seems to provide the most useable UI-enhancement with a small change without any unwanted side-effects.
Number 2 seems to has a slight side-effect on the project-overview block and the news index view where trailing new-lines are added. Number 1 seems a good start considering related issue #3740 but therefor also seems to have a higher severity when integrating it in the current state of Redmine (before 0.9 feature freeze).

NB: With all these patches there exists a chance that the users enter comments with markup which /could/ make the UI break. It should be handled with care. This might also be a good reason to decline all off the three patches...

Actions #8

Updated by Jean-Philippe Lang about 14 years ago

Text formatting on documents index added in r3602.

Actions #9

Updated by Gustavo Gama almost 14 years ago

I'm attaching a improved (imho) version of Micha's third patch (the one that deals with time entry comments).

It 'textilizes' time entry comments and removes the length restriction. Also, the form text_fields to enter the time entries were replaced by text_areas's.

Actions #10

Updated by Terence Mill over 12 years ago

related with #8668 - missing WIki full textile for project overview

Actions #11

Updated by Ivan Cenov about 11 years ago

Terence Mill wrote:

related with #8668 - missing WIki full textile for project overview

Not missing on present day.

News are textilized
time entry comment are not textilized

Actions #12

Updated by Mischa The Evil about 11 years ago

Ivan Cenov wrote:

Terence Mill wrote:

related with #8668 - missing WIki full textile for project overview

Not missing on present day.

I've updated #8668 accordingly. Thanks for mentioning it.

Ivan Cenov wrote:

News are textilized

News items are indeed textilized, but not the news summary.

Actions #13

Updated by Dipan Mehta almost 11 years ago

+1. This is very useful.

When is this likely to be fully accomplished?

Actions #14

Updated by JW Fuchs over 7 years ago

+1
Textilization in the above mentioned areas would be helpful.

Actions #15

Updated by Marius BĂLTEANU about 7 years ago

The attached patch adds textilization to spent time comments also.

Actions #16

Updated by Marius BĂLTEANU about 7 years ago

Having textilization support for spent time comments is quite useful. Please let me know if tests are required for my patch.

Actions #17

Updated by Dipan Mehta over 6 years ago

The document and news already seems to have textilization support as it seems. Don't know since when though!

Can we also complete the last part as well?

Second oldest unresolved issue by now.

Actions #18

Updated by Go MAEDA about 2 years ago

  • Target version set to Unplanned backlogs
Actions #19

Updated by Takenori TAKAKI almost 2 years ago

+1 Textlization of the spent time comments would be very useful.
I confirmed that the patch posted by Marius Ionescu in #202#note-15 works with the latest version of trunk (r21619).
I made a patch with a little bit refactoring and additional test code, and attache it.

Actions #20

Updated by Go MAEDA 10 months ago

  • Target version changed from Unplanned backlogs to 5.1.0

Setting the target version to 5.1.

Actions #21

Updated by Go MAEDA 5 months ago

Takenori TAKAKI wrote in #note-19:

+1 Textlization of the spent time comments would be very useful.
I confirmed that the patch posted by Marius Ionescu in #202#note-15 works with the latest version of trunk (r21619).
I made a patch with a little bit refactoring and additional test code, and attache it.

Thank you for updating the patch but I think the patch should not render Markdown/Textile also in the Spent time tab of an issue.

Actions #22

Updated by Takenori TAKAKI 5 months ago

Go MAEDA wrote in #note-21:

Thank you for updating the patch but I think the patch should not render Markdown/Textile also in the Spent time tab of an issue.

Go Maeda, thanks for pointing that out #note-21.
I have made a patch that fixes the problem you pointed out.
Please try the attached patch.

Actions

Also available in: Atom PDF