Project

General

Profile

Actions
Copy link

Defect #44273

closed

Applications item is not highlighted in the administration menu

Added by Liane Hampe about 1 month ago. Updated 12 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Administration
Target version:
6.1.4
Resolution:
Fixed
Affected version:

Description

The admin menu does not highlight the current menu item in sidebar when the admin user is on the Outh2 Application page. This patch adds the menu item highlight.

Before:

After:

A patch is provided based on RM 6.1.3.

Files

Download all files
add_menu_item_highlighting_on_oauth_application_controller.patch (557 Bytes) add_menu_item_highlighting_on_oauth_application_controller.patch Liane Hampe, 2026-07-18 16:31
screenshot-applications-with-menu-highlight.png (82.4 KB) screenshot-applications-with-menu-highlight.png Liane Hampe, 2026-07-18 16:31
screenshot-applications-without-menu-highlight.png (77.5 KB) screenshot-applications-without-menu-highlight.png Liane Hampe, 2026-07-18 16:31
add_menu_item_highlighting_on_oauth_application_controllerーv2.patch (1012 Bytes) add_menu_item_highlighting_on_oauth_application_controllerーv2.patch Go MAEDA, 2026-08-16 07:22
Actions
Copy link
 #1

Updated by Go MAEDA about 1 month ago

  • Tracker changed from Patch to Defect
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
Actions
Copy link
 #2

Updated by Go MAEDA 14 days ago

Thank you for reporting this and for the patch.

I made two changes to the patch:

  • Removed include Redmine::MenuManager::MenuController from Oauth2ApplicationsController. ApplicationController already includes it, so menu_item is available through inheritance.
  • Added an assertion to the existing system test in test/system/oauth_provider_test.rb

Setting the target version to 6.1.4.

Actions
Copy link
 #3

Updated by Go MAEDA 14 days ago

  • Subject changed from Add menu item highlighting on oauth application controller to Applications item is not highlighted in the administration menu
Actions
Copy link
 #4

Updated by Go MAEDA 13 days ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix in r24903. Thank you for catching and fixing the issue.

Actions
Copy link
 #5

Updated by Go MAEDA 12 days ago

  • Status changed from Resolved to Closed

Merged the fix into the stable branches in r24920 and r24922.

Actions
Copy link

Also available in: Atom PDF