Project

General

Profile

Actions

Defect #44317

closed

Actions dropdown is not closed after copying a link

Added by Mizuki ISHIKAWA 23 days ago. Updated 2 days ago.

Status:
Closed
Priority:
Normal
Category:
UI
Target version:
Resolution:
Fixed
Affected version:

Description

copyText in app/javascript/controllers/clipboard_controller.js closes the dropdown by looking for the nearest .drdn.expanded element from the clicked element and removing the expanded class from it:

    this.copy(e.currentTarget.dataset.clipboardText);

    const element = e.currentTarget.closest('.drdn.expanded');
    if (element !== null) {
      element.classList.remove('expanded');
    }

Since Patch #44205: Refactor actions dropdown to new dropdown component, actions_dropdown no longer uses that markup: it renders the new dropdown component, which is driven by dropdown_controller and hides its content with the hidden class instead. The selector above therefore matches nothing, and the dropdown is left open.


Files


Related issues

Related to Redmine - Patch #44205: Refactor actions dropdown to new dropdown componentClosedMarius BĂLTEANUActions
Actions

Also available in: Atom PDF