Patch #44341
closed
Increase top menu hover highlight by increasing the padding of the elements
Description
The top menu highlights the entry under the cursor with a background color, but the highlight is only as tall and as wide as the label itself.
The attached patch makes the links fill the bar. The links become flex boxes with their own padding, so the highlight spans the full height of the bar and extends slightly past the label.
Everything else stays where it is. Labels, avatar and bar height are unchanged.
The classic theme draws icons behind the top menu links with padding-inline-start and background-position; both are shifted by 6px so that its labels and icons also stay in place.
Files
Related issues
Updated by
Updated by Marius BĂLTEANU 15 days ago
- Related to Patch #44293: Add a caret to the account menu to indicate it opens a dropdown added
Updated by Marius BĂLTEANU 15 days ago
- Related to Defect #44351: Fix top menu position in Classic theme added
Updated by Marius BĂLTEANU 15 days ago
- File 0001-Improve-top-menu-hover-44341.patch 0001-Improve-top-menu-hover-44341.patch added
- File clipboard-202608190037-mpymz.png clipboard-202608190037-mpymz.png added
- File 0002-Top-menu-hover-highlight-cover-the-height-of-the-bar.patch 0002-Top-menu-hover-highlight-cover-the-height-of-the-bar.patch added
I like the improvement, but I think we can achieve (almost) the same with less changes, please find below two patches:
1. 0001-Improve-top-menu-hover-44341.patch
Minimal changes that improve the current hover state of the top menu, but without covering the full height of the top menu. Now, the top menu behaves similarly to the main menu. It also adds the hover effect to the account menu:
2. 0002-Top-menu-hover-highlight-cover-the-height-of-the-bar.patch
This change the hover to cover the full height of the top menu.
Both patches applies on top of #44293.
Updated by Marius BĂLTEANU 10 days ago
- Subject changed from Top menu hover highlight does not cover the height of the bar to Increase top menu hover highlight by increasing the padding of the elements
- Status changed from New to Resolved
Committed the first patch. If full-height hover for the top menu is still considered an improvement, please open a separate issue to discuss it further.
Updated by Marius BĂLTEANU 10 days ago
- Target version changed from Candidate for next major release to 7.0.1