Actions
Patch #44598
openRemove remaining JRuby-specific code and comments
Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
Description
Redmine no longer supports JRuby, and most of the code related to JRuby was removed in Redmine 4.1.0 (#29441). However, some code, test conditions, and comments that were written for JRuby still remain in the source. For example, config/configuration.yml.example still contains a note about "Windows + JRuby 1.6.2".
I would like to propose removing them. The attached patch removes the following:
- Code
Redmine::Platform.mswin?: the check forRUBY_PLATFORM 'java'Redmine::Utils::Shell.shell_quote_command: the branch for JRuby on Windows that returns the command without quotingRedmine::Scm::Adapters::AbstractAdapter#parse_xml: the workaround that removes the XML declaration on JRubyextra/svn/reposman.rb: the check forRUBY_PLATFORM 'java'inmswin?lib/tasks/ci.rake: the selection of thejdbcsqlite3adapter
- Tests
test/test_helper.rb: the replacement of backslashes inrepository_path, which was needed only for JRuby on Windowstest/unit/lib/redmine/scm/adapters/git_adapter_test.rb: theJRUBY_SKIPandJRUBY_SKIP_STRconstants, the six branches that skip tests on JRuby, and the comment that explains why they were skippedtest/unit/repository_bazaar_test.rb: the JRuby condition inRUN_LATIN1_OUTPUT_TESTtest/unit/lib/redmine/export/pdf_test.rb: the selection of the "SJIS" encoding on JRuby
- Comments
config/configuration.yml.example: the note about paths that contain spaces on "Windows + JRuby 1.6.2". In addition, "On Windows + CRuby" is changed to "On Windows", because the distinction is no longer necessary.
The patch does not change the behavior on CRuby, because all the removed code was executed only on JRuby.
Files
Related issues
Updated by Go MAEDA about 11 hours ago
- Related to Patch #29441: Remove code related to JRuby and unsupported Ruby versions added
Actions