Patch #29441

Remove code related to JRuby and unsupported Ruby versions

Added by Marius BALTEANU over 1 year ago. Updated 8 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Jean-Philippe Lang% Done:

0%

Category:Code cleanup/refactoring
Target version:4.1.0

code_cleanup.patch Magnifier (4.44 KB) Marius BALTEANU, 2018-08-26 14:27

29411-gemfile.diff Magnifier (737 Bytes) Go MAEDA, 2018-11-27 12:17


Related issues

Related to Redmine - Defect #31387: Don't rescue Exception class Closed
Related to Redmine - Patch #32937: test_revisions_latin_1_identifier should be skipped on Wi... Closed

Associated revisions

Revision 18294
Added by Jean-Philippe Lang 8 months ago

Remove code related to JRuby and unsupported Ruby versions (#29441).

Patch by Marius BALTEANU.

Revision 18295
Added by Jean-Philippe Lang 8 months ago

Remove code related to JRuby and unsupported Ruby versions (#29441).

Patch by Go MAEDA.

History

#1 Updated by Go MAEDA over 1 year ago

  • Target version changed from Candidate for next major release to 4.1.0

#2 Updated by Go MAEDA over 1 year ago

  • Assignee set to Jean-Philippe Lang

#3 Updated by Jeremy Bailey over 1 year ago

It might be interesting to mention hear that the TruffleRuby team is making rapid progress, and I’ve reported a few issues they are actively working on that will eventually allow Redmine (and other production Rails apps) to run, considerably faster than MRI. TruffleRuby is based on JRuby but adds a lot to it. I hope Redmine will officially support it when compatibility is achieved.

#4 Updated by Holger Just over 1 year ago

TruffleRuby is way less mature that JRuby. Also, it doesn't solve the issue that many external gems used by Redmine do not fully support JRuby (and even less likely TruffleRuby). Thus, while Truffle is interesting, full support for it likely requires a long way to go.

#5 Updated by Pavel Rosický over 1 year ago

lower your expectations, TruffleRuby will definitely excel in numeric operations (micro-benchmarks), partial evaluation is also an interesting technique, but a webserver is usually limited by IO (handling requests, database access etc.) so I don't expect it'll be MUCH faster.

#6 Updated by Go MAEDA about 1 year ago

Gemfile also has JRuby related code that can be removed.

#7 Updated by Go MAEDA 9 months ago

#8 Updated by Jean-Philippe Lang 8 months ago

  • Status changed from New to Closed

Committed, thanks.

#9 Updated by Go MAEDA 22 days ago

  • Related to Patch #32937: test_revisions_latin_1_identifier should be skipped on Windows added

Also available in: Atom PDF