Project

General

Profile

Actions
Copy link

Patch #44701

open

Remove unused wiki toolbar icons

Added by Go MAEDA about 18 hours ago. Updated about 15 hours ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Code cleanup/refactoring
Target version:
7.1.0

Description

The attached patch removes the following files from app/assets/images/jstoolbar, which are no longer used:

  • bt_*.png (18 files)
  • checklist.svg

r23033 (#23980) replaced the PNG images of the wiki toolbar buttons with SVG icons, and r23122 (#23980) did the same for the syntax help pages. Neither revision removed the PNG files. checklist.svg has been unused since r23084 (#23980), which changed the toolbar to use list-check.svg.

Files

0001-Remove-unused-wiki-toolbar-icons.patch (14.5 KB) 0001-Remove-unused-wiki-toolbar-icons.patch Go MAEDA, 2026-11-02 05:11
Actions
Copy link
 #1

Updated by Marius BĂLTEANU about 15 hours ago

Shouldn't we keep all the legacy icons until 8.0.0 and remove them all at once, rather than removing just a portion of them in 7.1.0? I'm not sure why we remove some of the images (this and #44702), and others not.

Actions
Copy link
 #2

Updated by Go MAEDA about 15 hours ago

I agree that the legacy icons should be kept until they can all be removed at once. However, I think the images in this issue and #44702 are leftovers rather than legacy icons kept for compatibility.

legacy-icons-compat.css does not reference them, and application.css had already stopped referencing them when r24103 added that file.

The images that legacy-icons-compat.css references are not affected by these patches. That said, there is no urgency to remove these images, and I am fine with postponing this to a future version such as 8.0.0 if you prefer.

Actions
Copy link

Also available in: Atom PDF